Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues about deployment step #63

Closed
weixuanfu opened this issue Jun 18, 2020 · 2 comments
Closed

Issues about deployment step #63

weixuanfu opened this issue Jun 18, 2020 · 2 comments

Comments

@weixuanfu
Copy link
Contributor

weixuanfu commented Jun 18, 2020 •
edited
Loading

After some tests in Github, our current deployment step works only on pull requests from a branch in this repo but does not work with a branch in a forked repo. Also somehow the deployment step failed in git push.

Additionally, I think the right behavior should be that deployment step only run if a pull request or commit is merged into PMLB2.0 or master branch.

I will check on it next week.
@weixuanfu weixuanfu changed the title Isssue about deployment step Isssues about deployment step Jun 18, 2020
@weixuanfu weixuanfu changed the title Isssues about deployment step Issues about deployment step Jun 18, 2020
@trangdata
Copy link
Collaborator

I just opened an issue here.

@trangdata trangdata mentioned this issue Jul 6, 2020
Closed
@trangdata trangdata mentioned this issue Jul 28, 2020
Merged
@trangdata
Copy link
Collaborator

This has now been resolved in v1.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trangdata @weixuanfu