Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The _peak_level function is not robust enough #81

Open
XingdaChen1996 opened this issue Feb 18, 2024 · 2 comments
Open

The _peak_level function is not robust enough #81

XingdaChen1996 opened this issue Feb 18, 2024 · 2 comments

Comments

@XingdaChen1996
Copy link

image

The _peak_level function is not robust enough

When I called the tnr_ecma_st function (_peak_level was called in the function body), I found that changing the length of the first formal parameter "signal" of the tnr_ecma_st function would make tr very unrobust.
Therefore, I changed if Li - spec[temp] < 10 to if Li - spec[temp] < 50. I found that the robustness of tr improved a lot.
image

@XingdaChen1996
Copy link
Author

High-resolution Spectral Analysis(HSA) may also be able to solve this problem. It can greatly improve the resolution and accuracy of single-frequency signals without extending the time signal.

@wantysal
Copy link
Collaborator

wantysal commented Mar 5, 2024

Hi,

We've already encoutered some issues with this function, there is indeed some conditions lacking to be more robust. HSA could be a great way to overcome this, but there is no existing implementation of it, and the available documentation is not very detailed... If you have some references (articles, codes, ...) concerning the HSA, you can share it here so that we try to work on it ...

We'll try to incorporate a fix in a coming release, I'll keep you updated.
Tks,
Salomé

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants