Skip to content

Forward Mode CallInst #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 7, 2021
Merged

Forward Mode CallInst #297

merged 7 commits into from
Sep 7, 2021

Conversation

@tgymnich
Copy link
Member

@tgymnich tgymnich commented Aug 13, 2021 •
edited
Loading

TODO:

  • handle CallInst
  • Checks and debug messages
  • Tests

@tgymnich tgymnich self-assigned this Aug 13, 2021
@tgymnich tgymnich force-pushed the ForwardMode-CallInst branch from 6798c48 to 94e4c7b Compare August 14, 2021 21:25
@tgymnich tgymnich changed the title Forward mode CallInst Forward Mode CallInst Aug 15, 2021
@tgymnich tgymnich force-pushed the ForwardMode-CallInst branch 4 times, most recently from ff5264e to 32306e2 Compare August 18, 2021 21:37
wsmoses
wsmoses reviewed Aug 18, 2021
View reviewed changes
@tgymnich tgymnich force-pushed the ForwardMode-CallInst branch 3 times, most recently from fa7db86 to f75f311 Compare August 19, 2021 07:02
@tgymnich tgymnich marked this pull request as ready for review August 20, 2021 08:25
@tgymnich tgymnich marked this pull request as draft August 20, 2021 11:07
@tgymnich tgymnich requested a review from wsmoses August 20, 2021 18:32
@tgymnich tgymnich marked this pull request as ready for review August 20, 2021 18:33
@tgymnich tgymnich force-pushed the ForwardMode-CallInst branch 2 times, most recently from fc4a719 to f52e8cd Compare September 1, 2021 15:18
@tgymnich tgymnich force-pushed the ForwardMode-CallInst branch from f52e8cd to 23e872f Compare September 2, 2021 13:59
wsmoses
wsmoses reviewed Sep 3, 2021
View reviewed changes
enzyme/Enzyme/AdjointGenerator.h Outdated
}
#endif

if (!diffes->getType()->isVoidTy()) {
Copy link
Member

@wsmoses wsmoses Sep 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this not be a check whether the value returned by the call is constant?

Copy link
Member Author

@tgymnich tgymnich Sep 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes!

@tgymnich tgymnich force-pushed the ForwardMode-CallInst branch from 08a7e7d to dbdf14e Compare September 6, 2021 20:22
@tgymnich tgymnich force-pushed the ForwardMode-CallInst branch from dbdf14e to b18cf57 Compare September 6, 2021 21:26
@tgymnich tgymnich force-pushed the ForwardMode-CallInst branch from b18cf57 to e210b5b Compare September 6, 2021 22:02
@tgymnich tgymnich merged commit 9c10f97 into main Sep 7, 2021
@tgymnich tgymnich deleted the ForwardMode-CallInst branch September 7, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wsmoses wsmoses wsmoses approved these changes

Assignees

@tgymnich tgymnich

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tgymnich @wsmoses