Assertion `VMap[invertedRetPs[ri]]' failed

[ZuseZ4]

Another (somewhat larger) variation of #720 and #677 triggered the assertion above.
Passed you the stacktrace on Slack.

[wsmoses]

https://fwd.gymni.ch/MyFGes

[wsmoses]

Minimized LLVM: https://fwd.gymni.ch/ZHVQgV

@_ZTId = external dso_local constant i8*

; Function Attrs: mustprogress nounwind uwtable
define void @_Z18compute_1body_intsv() {
  %a4 = alloca i8*, align 8
  call void @_ZN4implIdEC2IdEEOT_(i8** %a4)
  ret void
}

define linkonce_odr dso_local void @_ZN4implIdEC2IdEEOT_(i8** %a4) {
  store i8* bitcast (i8* ()* @_ZNK4implIdE4typeEv to i8*), i8** %a4, align 8
  ret void
}

define void @_Z18wrapper_1body_intsv()  {
  call void @_Z17__enzyme_autodiffPv(i8* bitcast (void ()* @_Z18compute_1body_intsv to i8*))
  ret void
}

declare void @_Z17__enzyme_autodiffPv(i8*)

define i8* @_ZNK4implIdE4typeEv()  {
  ret i8* bitcast (i8** @_ZTId to i8*)
}

[wsmoses]

@_ZTId = external dso_local constant i8*

define i8* @_ZNK4implIdE4typeEv()  {
  ret i8* bitcast (i8** @_ZTId to i8*)
}

declare void @_Z17__enzyme_virtualreverse(i8*)

define void @_Z18wrapper_1body_intsv()  {
  call void @_Z17__enzyme_virtualreverse(i8* bitcast (i8* ()* @_ZNK4implIdE4typeEv to i8*))
  ret void
}

[ZuseZ4]

Updating enzymeLogic.cpp to also consider ConstantExpr instead of only ConstantData around line 2620 will result in the following code:

; ModuleID = '<stdin>'
source_filename = "bug.ll"

@_ZTId_shadow = constant i8* null
@_ZTId = external dso_local constant i8*, !enzyme_shadow !0
@"_enzyme_reverse__ZNK4implIdE4typeEv'" = internal constant { { i8*, i8*, i8* } ()*, void (i8*)* } { { i8*, i8*, i8* } ()* @augmented__ZNK4implIdE4typeEv, void (i8*)* @diffe_ZNK4implIdE4typeEv }

define i8* @_ZNK4implIdE4typeEv() {
  ret i8* bitcast (i8** @_ZTId to i8*)
}

; Function Attrs: readnone
declare void @_Z17__enzyme_virtualreverse(i8* nocapture readnone) #0

define void @_Z18wrapper_1body_intsv() {
  ret void
}

; Function Attrs: mustprogress willreturn
define internal { i8*, i8*, i8* } @augmented__ZNK4implIdE4typeEv() #1 {
  %1 = alloca { i8*, i8*, i8* }, align 8
  %2 = getelementptr inbounds { i8*, i8*, i8* }, { i8*, i8*, i8* }* %1, i32 0, i32 0
  store i8* null, i8** %2, align 8
  %3 = getelementptr inbounds { i8*, i8*, i8* }, { i8*, i8*, i8* }* %1, i32 0, i32 1
  store i8* bitcast (i8** @_ZTId to i8*), i8** %3, align 8
  %4 = getelementptr inbounds { i8*, i8*, i8* }, { i8*, i8*, i8* }* %1, i32 0, i32 2
  store i8* bitcast (i8** @_ZTId_shadow to i8*), i8** %4, align 8
  %5 = load { i8*, i8*, i8* }, { i8*, i8*, i8* }* %1, align 8
  ret { i8*, i8*, i8* } %5
}

; Function Attrs: mustprogress willreturn
define internal void @diffe_ZNK4implIdE4typeEv(i8* %tapeArg) #1 {
  tail call void @free(i8* nonnull %tapeArg)
  br label %invert

invert:                                           ; preds = %0
  ret void
}

declare void @free(i8*)

attributes #0 = { readnone }
attributes #1 = { mustprogress willreturn }

!0 = !{i8** @_ZTId_shadow}

Just skipping constantExpr will also make the compilation succeed, but not emit
store i8* bitcast (i8** @_ZTId_shadow to i8*), i8** %4, align 8
Given that ConstExpr just seem to be a constant data with an init expresion, I don't think that we need any further handling,
so I can just submit a PR? Also, how about the other constant types?

[wsmoses]

That still merits some investigation, since regardless shouldn't there be an entry generated from here: https://github.com/EnzymeAD/Enzyme/blob/e8ed87c549f07621f591d90ff91a445a6873f34c/enzyme/Enzyme/EnzymeLogic.cpp#L2301

…

On Wed, Jul 20, 2022 at 1:42 PM Manuel Drehwald ***@***.***> wrote: Updating enzymeLogic.cpp to also consider ConstantExpr instead of only ConstantData around line 2620 will result in the following code: ; ModuleID = '<stdin>' source_filename = "bug.ll" @_ZTId_shadow = constant i8* null@_ZTId = external dso_local constant i8*, !enzyme_shadow !0 @"_enzyme_reverse__ZNK4implIdE4typeEv'" = internal constant { { i8*, i8*, i8* } ()*, void (i8*)* } { { i8*, i8*, i8* } ()* @augmented__ZNK4implIdE4typeEv, void (i8*)* @diffe_ZNK4implIdE4typeEv } define i8* @_ZNK4implIdE4typeEv() { ret i8* bitcast (i8** @_ZTId to i8*) } ; Function Attrs: readnonedeclare void @_Z17__enzyme_virtualreverse(i8* nocapture readnone) #0 define void @_Z18wrapper_1body_intsv() { ret void } ; Function Attrs: mustprogress willreturndefine internal { i8*, i8*, i8* } @augmented__ZNK4implIdE4typeEv() #1 { %1 = alloca { i8*, i8*, i8* }, align 8 %2 = getelementptr inbounds { i8*, i8*, i8* }, { i8*, i8*, i8* }* %1, i32 0, i32 0 store i8* null, i8** %2, align 8 %3 = getelementptr inbounds { i8*, i8*, i8* }, { i8*, i8*, i8* }* %1, i32 0, i32 1 store i8* bitcast (i8** @_ZTId to i8*), i8** %3, align 8 %4 = getelementptr inbounds { i8*, i8*, i8* }, { i8*, i8*, i8* }* %1, i32 0, i32 2 store i8* bitcast (i8** @_ZTId_shadow to i8*), i8** %4, align 8 %5 = load { i8*, i8*, i8* }, { i8*, i8*, i8* }* %1, align 8 ret { i8*, i8*, i8* } %5 } ; Function Attrs: mustprogress willreturndefine internal void @diffe_ZNK4implIdE4typeEv(i8* %tapeArg) #1 { tail call void @free(i8* nonnull %tapeArg) br label %invert invert: ; preds = %0 ret void } declare void @free(i8*) attributes #0 = { readnone }attributes #1 = { mustprogress willreturn } !0 = !{i8** @_ZTId_shadow} Just skipping constantExpr will also make the compilation succeed, but not emit store i8* bitcast (i8** @_ZTId_shadow to i8*), i8** %4, align 8 Given that ConstExpr just seem to be a constant data with an init expresion, I don't think that we need any further handling, so I can just submit a PR? Also, how about the other constant types? — Reply to this email directly, view it on GitHub <#721 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJTUXF4IXD5DJHYVTXMY53VVA27LANCNFSM5Z74T7JQ> . You are receiving this because you commented.Message ID: ***@***.***>

[tgymnich]

That still merits some investigation, since regardless shouldn't there be an entry generated from here:

Enzyme/enzyme/Enzyme/EnzymeLogic.cpp

Line 2301 in e8ed87c

invertedRetPs[newri] = gutils->invertPointerM(orig_oldval, BuilderZ);

+1
I found shadowReturnUsed to be true on macOS and false on Linux. Maybe we should open another issue to keep track of this discrepancy.