Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input full path to cache directory #1707

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

nuno-agostinho
Copy link
Contributor

Add new --full_cache_dir option to set cache directory directly and check if given directory exists

@nakib103, should we improve the logic to check if the directory is a VEP cache dir? How would we do this?

Testing

Run VEP with:

  • --full_cache_dir with a non-existing directory: should raise error
  • --full_cache_dir with a VEP cache dir: should work as expected
  • --cache_dir and --full_cache_dir with a VEP cache dir: should ignore --cache_dir
  • --cache_dir as usual: should work as expected

@nuno-agostinho nuno-agostinho requested a review from nakib103 June 26, 2024 13:55
@nuno-agostinho nuno-agostinho changed the title Input direct path to cache directory Input full path to cache directory Jun 26, 2024
Copy link
Contributor

@nakib103 nakib103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nuno-agostinho,

Everything is working as expected, thanks!

As for the checking if the --full_cache_dir is actually cache dir - we do not check for that with --dir_cache either. It would be nice but not mandatory I would say. User currently get warning -

variant .. not found in annotation sources or synonyms

But a clear warning of it happened because of faulty cache directory would be better.

We can add checking for the presence of info.txt file here and further checking if species and assembly matches if present in config.

Copy link
Contributor

@nakib103 nakib103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking if the cache dir is a proper is not mandatory. Something that can be added later on. LOTM!~

@nakib103 nakib103 merged commit 560b409 into Ensembl:main Jul 17, 2024
1 check passed
@nuno-agostinho nuno-agostinho deleted the add/full-cache-dir branch July 17, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants