Update Gradle setup to use Crankcase

Author: me4502

.github/workflows/gradle.yml

@@ -11,30 +11,30 @@ jobs:
         os: [ubuntu-latest, windows-latest]
 
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
 
       - name: Set up JDK
-        uses: actions/setup-java@v4
+        uses: actions/setup-java@v5
         with:
-          java-version: 21
+          java-version: 25
           distribution: 'temurin'
 
       - name: Setup Gradle
-        uses: gradle/actions/setup-gradle@v3
+        uses: gradle/actions/setup-gradle@v5
         with:
           cache-read-only: ${{ !(github.ref == 'refs/heads/master' || github.ref == 'refs/heads/five') }}
 
       - name: Execute Gradle build
         run: ./gradlew build -s
 
-      - uses: actions/upload-artifact@v4
+      - uses: actions/upload-artifact@v6
         name: Archive Reports
         if: always()
         with:
           name: reports for ${{ matrix.os }}
           path: '**/build/reports/**'
 
-      - uses: actions/upload-artifact@v4
+      - uses: actions/upload-artifact@v6
         name: Archive Logs
         if: always()
         with:

build-logic/build.gradle.kts

@@ -3,19 +3,24 @@ plugins {
 }
 
 repositories {
-    gradlePluginPortal()
     maven {
-        name = "EngineHub Repository"
-        url = uri("https://maven.enginehub.org/repo/")
+        name = "EngineHub"
+        url = uri("https://repo.enginehub.org/libs-release/")
     }
+    mavenCentral()
+    gradlePluginPortal()
 }
 
 dependencies {
     implementation(gradleApi())
+    implementation(libs.crankcase.java)
+    implementation(libs.crankcase.javaLibrary)
+    implementation(libs.crankcase.common)
+    implementation(libs.crankcase.licensing)
+    implementation(libs.crankcase.git)
+    implementation(libs.crankcase.publishing)
     implementation(libs.levelHeadered)
     implementation(libs.shadow)
-    implementation(libs.jfrog.buildinfo)
-    implementation(libs.errorprone.gradle.plugin)
     implementation(libs.gson)
 
     constraints {

build-logic/settings.gradle.kts

@@ -1,3 +1,36 @@
+pluginManagement {
+    // pluginManagement repositories resolve plugins before the repo-reconfiguration plugin can
+    // apply, so they must point at EngineHub mirrors directly rather than upstream URLs.
+    repositories {
+        maven {
+            name = "EngineHub"
+            url = uri("https://repo.enginehub.org/libs-release/")
+            mavenContent {
+                releasesOnly()
+                includeGroupAndSubgroups("com.sk89q")
+                includeGroupAndSubgroups("org.enginehub")
+            }
+        }
+        maven {
+            name = "EngineHub Maven Central Mirror"
+            url = uri("https://repo.enginehub.org/internal/maven-central-proxy/")
+            mavenContent {
+                releasesOnly()
+            }
+        }
+        maven {
+            name = "EngineHub Gradle Plugin Portal Mirror"
+            url = uri("https://repo.enginehub.org/internal/plugin-portal-proxy/")
+            mavenContent {
+                releasesOnly()
+            }
+        }
+    }
+}
+plugins {
+    id("org.enginehub.crankcase.repo-reconfiguration") version "0.1.2"
+}
+
 dependencyResolutionManagement {
     versionCatalogs {
         create("libs") {

build-logic/src/main/kotlin/buildlogic.artifactory-root.gradle.kts

@@ -0,0 +1,11 @@
+import buildlogic.getLibrary
+import buildlogic.stringyLibs
+
+plugins {
+    id("org.enginehub.crankcase.java-library")
+    id("buildlogic.common-java")
+}
+
+dependencies {
+    "compileOnlyApi"(stringyLibs.getLibrary("errorprone-annotations"))
+}

build-logic/src/main/kotlin/buildlogic.artifactory-sub.gradle.kts

@@ -1,44 +1,25 @@
 import buildlogic.stringyLibs
 import buildlogic.getLibrary
-import net.ltgt.gradle.errorprone.errorprone
 
 plugins {
     id("eclipse")
     id("idea")
     id("checkstyle")
-    id("net.ltgt.errorprone")
+    id("org.enginehub.crankcase.java")
     id("buildlogic.common")
 }
 
-tasks
-    .withType<JavaCompile>()
-    .matching { it.name == "compileJava" || it.name == "compileTestJava" }
-    .configureEach {
-        val disabledLint = listOf(
-            "processing", "path", "fallthrough", "serial", "overloads", "this-escape",
-        )
-        options.release.set(21)
-        options.compilerArgs.addAll(listOf("-Xlint:all") + disabledLint.map { "-Xlint:-$it" })
-        options.isDeprecation = true
-        options.encoding = "UTF-8"
-        options.compilerArgs.add("-parameters")
-        if (project.name.contains("-core")) {
-            options.compilerArgs.add("-Werror")
-        }
-        options.errorprone {
-            // We use -Werror, so we don't need errorprone to fail the build separately
-            allErrorsAsWarnings = true
-            // Obviously we don't need to fix generated code
-            disableWarningsInGeneratedCode = true
-            // We use reference equality intentionally in several places
-            // Perhaps we should consider testing the performance impact of using .equals() instead?
-            // Especially for the types that are only compared by reference equality, we could consider
-            // removing their .equals() implementations to avoid confusion.
-            disable("ReferenceEquality")
-            // We're on JDK 21, so System.console() can still be null
-            disable("SystemConsoleNull")
-        }
-    }
+crankcaseJava {
+    javaRelease = 21
+    disabledLints = listOf("processing", "path", "fallthrough", "serial", "overloads", "this-escape")
+    disabledErrorprone = listOf(
+        // We use reference equality intentionally in several places
+        "ReferenceEquality",
+        // We're on JDK 21, so System.console() can still be null
+        "SystemConsoleNull",
+    )
+    failOnWarnings = project.name.contains("-core")
+}
 
 configure<CheckstyleExtension> {
     configFile = rootProject.file("config/checkstyle/checkstyle.xml")
@@ -53,38 +34,9 @@ tasks.withType<Test>().configureEach {
 
 dependencies {
     "compileOnly"(stringyLibs.getLibrary("jspecify"))
-    "compileOnly"(stringyLibs.getLibrary("errorprone-annotations"))
-    "errorprone"(stringyLibs.getLibrary("errorprone-core"))
-    "testImplementation"(platform(stringyLibs.getLibrary("junit-bom")))
-    "testImplementation"(stringyLibs.getLibrary("junit-jupiter-api"))
-    "testImplementation"(stringyLibs.getLibrary("junit-jupiter-params"))
     "testImplementation"(platform(stringyLibs.getLibrary("mockito-bom")))
     "testImplementation"(stringyLibs.getLibrary("mockito-core"))
     "testImplementation"(stringyLibs.getLibrary("mockito-junit-jupiter"))
-    "testRuntimeOnly"(stringyLibs.getLibrary("junit-jupiter-engine"))
-    "testRuntimeOnly"(stringyLibs.getLibrary("junit-platform-launcher"))
-}
-
-// Java 8 turns on doclint which we fail
-tasks.withType<Javadoc>().configureEach {
-    options.encoding = "UTF-8"
-    (options as StandardJavadocDocletOptions).apply {
-        if (project.name.contains("-core")) {
-            addBooleanOption("Werror", true)
-        }
-        addBooleanOption("Xdoclint:all", true)
-        addBooleanOption("Xdoclint:-missing", true)
-        tags(
-            "apiNote:a:API Note:",
-            "implSpec:a:Implementation Requirements:",
-            "implNote:a:Implementation Note:"
-        )
-    }
-}
-
-configure<JavaPluginExtension> {
-    withJavadocJar()
-    withSourcesJar()
 }
 
 tasks.named("check").configure {

build-logic/src/main/kotlin/buildlogic.common-java-library.gradle.kts

@@ -1,9 +1,10 @@
 import buildlogic.getLibrary
 import buildlogic.stringyLibs
-import org.gradle.plugins.ide.idea.model.IdeaModel
 
 plugins {
-    id("net.octyl.level-headered")
+    id("org.enginehub.crankcase.common")
+    id("org.enginehub.crankcase.licensing")
+    id("org.enginehub.crankcase.git")
 }
 
 group = rootProject.group
@@ -13,19 +14,7 @@ repositories {
     mavenCentral()
     maven {
         name = "EngineHub"
-        url = uri("https://maven.enginehub.org/repo/")
-    }
-}
-
-configurations.all {
-    resolutionStrategy {
-        cacheChangingModulesFor(1, TimeUnit.DAYS)
-    }
-}
-
-plugins.withId("java") {
-    the<JavaPluginExtension>().toolchain {
-        languageVersion.set(JavaLanguageVersion.of(21))
+        url = uri("https://repo.enginehub.org/repo/")
     }
 }
 
@@ -54,20 +43,9 @@ dependencies {
 }
 
 levelHeadered {
-    headerTemplate(rootProject.file("HEADER.txt"))
-
     sourceMatchPatterns {
         // Exclude overrides for shaded libs
         exclude("org/enginehub/craftbook/util/jinglenote/")
         exclude("org/enginehub/craftbook/util/profile/")
     }
 }
-
-plugins.withId("idea") {
-    configure<IdeaModel> {
-        module {
-            isDownloadSources = true
-            isDownloadJavadoc = true
-        }
-    }
-}

build-logic/src/main/kotlin/buildlogic.common-java.gradle.kts

@@ -1,8 +1,7 @@
 plugins {
-    id("java")
     id("maven-publish")
-    id("buildlogic.common-java")
-    id("buildlogic.artifactory-sub")
+    id("buildlogic.common-java-library")
+    id("org.enginehub.crankcase.publishing")
 }
 
 publishing {

build-logic/src/main/kotlin/buildlogic.common.gradle.kts

@@ -2,9 +2,8 @@ plugins {
     id("java-base")
     id("maven-publish")
     id("com.gradleup.shadow")
-    id("com.jfrog.artifactory")
     id("buildlogic.common")
-    id("buildlogic.artifactory-sub")
+    id("org.enginehub.crankcase.publishing")
 }
 
 // A horrible hack because `softwareComponentFactory` has to be gotten via plugin