platform/windows_x64: update container image and toolchain for wrapper (#244)

The Windows MSVC toolchain now invokes a wrapper binary when compiling
instead of cl.exe. The wrapper binary invokes cl.exe with all arguments
but filters /showincludes output, removing EngFlow execroot paths.

For example, the line:

    Note: including file: C:\worker\work\2\exec\cpp\hello.h

is replaced with:

    Note: including file: cpp\hello.h

This is a workaround for bazelbuild/bazel#19733. Bazel invokes the compiler
with /showincludes to dump all included headers in order to validate them.
It strips anything that looks like a local execroot directory followed by
the workspace name before performing that validation. EngFlow execroot
directories don't look like local execroot directories though. We also don't
know Bazel's workspace name, so we can't work around this issue on the
server side. Using a wrapper like this instead makes the CppCompile action
slightly more hermetic by filtering out those absolute paths.

For linear/CUS-81

We'll open source this wrapper tool in a follow-up.

Also: change line endings in cpp/main.cc to be LF instead of CRLF.

Author: jayconrod

cpp/main.cc

@@ -1,7 +1,7 @@
-#include <iostream>
-#include "cpp/hello.h"
-
-int main() {
-  std::cout << hello() << std::endl;
-  return 0;
-}
+#include <iostream>
+#include "cpp/hello.h"
+
+int main() {
+  std::cout << hello() << std::endl;
+  return 0;
+}

platform/windows_x64/BUILD

@@ -13,7 +13,7 @@ platform(
         "@io_bazel_rules_dotnet//dotnet/toolchain:6.0.101",
     ],
     exec_properties = {
-        "container-image": "docker://645088952840.dkr.ecr.eu-west-1.amazonaws.com/engflow-re/windows-x64:engflow_worker@sha256:bb3d3e9d908f1cfcefdf74b553f210eab5c4f46b8812aa91b6d971c016f23cfa",
+        "container-image": "docker://645088952840.dkr.ecr.eu-west-1.amazonaws.com/engflow-re/windows-x64:engflow_worker@sha256:47f826fcffd6eee8241e31d1fba044061e1cf5f35d53184a850d54282aecf956",
         "Pool": "windows",
     },
 )
@@ -76,7 +76,7 @@ cc_toolchain_config(
     default_link_flags = ["/MACHINE:X64"],
     fastbuild_mode_debug_flag = "/DEBUG:FASTLINK",
     host_system_name = "local",
-    msvc_cl_path = "C:/Program Files (x86)/Microsoft Visual Studio/2019/BuildTools/VC/Tools/MSVC/14.29.30133/bin/HostX64/x64/cl.exe",
+    msvc_cl_path = "C:/Program Files/engflow/bin/msvc_filter_showincludes.exe",
     msvc_env_include = "C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\BuildTools\\VC\\Tools\\MSVC\\14.29.30133\\include;C:\\Program Files (x86)\\Windows Kits\\10\\include\\10.0.19041.0\\ucrt;C:\\Program Files (x86)\\Windows Kits\\10\\include\\10.0.19041.0\\shared;C:\\Program Files (x86)\\Windows Kits\\10\\include\\10.0.19041.0\\um;C:\\Program Files (x86)\\Windows Kits\\10\\include\\10.0.19041.0\\winrt;C:\\Program Files (x86)\\Windows Kits\\10\\include\\10.0.19041.0\\cppwinrt",
     msvc_env_lib = "C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\BuildTools\\VC\\Tools\\MSVC\\14.29.30133\\lib\\x64;C:\\Program Files (x86)\\Windows Kits\\10\\lib\\10.0.19041.0\\ucrt\\x64;C:\\Program Files (x86)\\Windows Kits\\10\\lib\\10.0.19041.0\\um\\x64",
     msvc_env_path = "C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\BuildTools\\VC\\Tools\\MSVC\\14.29.30133\\bin\\HostX64\\x64;C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\BuildTools\\Common7\\IDE\\VC\\VCPackages;C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\BuildTools\\Common7\\IDE\\CommonExtensions\\Microsoft\\TestWindow;C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\BuildTools\\Common7\\IDE\\CommonExtensions\\Microsoft\\TeamFoundation\\Team Explorer;C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\BuildTools\\MSBuild\\Current\\bin\\Roslyn;C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\BuildTools\\Common7\\Tools\\devinit;C:\\Program Files (x86)\\Windows Kits\\10\\bin\\10.0.19041.0\\x64;C:\\Program Files (x86)\\Windows Kits\\10\\bin\\x64;C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\BuildTools\\\\MSBuild\\Current\\Bin;C:\\Windows\\Microsoft.NET\\Framework64\\v4.0.30319;C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\BuildTools\\Common7\\IDE\\;C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\BuildTools\\Common7\\Tools\\;;C:\\Windows\\system32;C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\BuildTools\\Common7\\IDE\\CommonExtensions\\Microsoft\\CMake\\CMake\\bin;C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\BuildTools\\Common7\\IDE\\CommonExtensions\\Microsoft\\CMake\\Ninja",
@@ -89,8 +89,8 @@ cc_toolchain_config(
     tool_paths = {
         "ar": "C:/Program Files (x86)/Microsoft Visual Studio/2019/BuildTools/VC/Tools/MSVC/14.29.30133/bin/HostX64/x64/lib.exe",
         "ml": "C:/Program Files (x86)/Microsoft Visual Studio/2019/BuildTools/VC/Tools/MSVC/14.29.30133/bin/HostX64/x64/ml64.exe",
-        "cpp": "C:/Program Files (x86)/Microsoft Visual Studio/2019/BuildTools/VC/Tools/MSVC/14.29.30133/bin/HostX64/x64/cl.exe",
-        "gcc": "C:/Program Files (x86)/Microsoft Visual Studio/2019/BuildTools/VC/Tools/MSVC/14.29.30133/bin/HostX64/x64/cl.exe",
+        "cpp": "C:/Program Files/engflow/bin/msvc_filter_showincludes.exe",
+        "gcc": "C:/Program Files/engflow/bin/msvc_filter_showincludes.exe",
         "gcov": "wrapper/bin/msvc_nop.bat",
         "ld": "C:/Program Files (x86)/Microsoft Visual Studio/2019/BuildTools/VC/Tools/MSVC/14.29.30133/bin/HostX64/x64/link.exe",
         "nm": "wrapper/bin/msvc_nop.bat",