From 737ed23e2276041931ca29c16832ad8c1f936510 Mon Sep 17 00:00:00 2001 From: Matthieu Riegler Date: Mon, 31 Jul 2023 14:42:11 +0200 Subject: [PATCH] refactor(core): removing reflect-metadata from symbol tests. (#51217) We were not reyling on it anymore. PR Close #51217 --- .../core/test/bundling/animation_world/BUILD.bazel | 1 - .../core/test/bundling/animation_world/index.ts | 2 -- packages/core/test/bundling/todo/BUILD.bazel | 2 -- packages/core/test/bundling/todo/index.ts | 2 -- packages/core/test/bundling/todo_i18n/BUILD.bazel | 2 -- packages/core/test/bundling/todo_i18n/index.ts | 1 - packages/core/test/bundling/util/BUILD.bazel | 14 -------------- .../test/bundling/util/src/reflect_metadata.ts | 9 --------- 8 files changed, 33 deletions(-) delete mode 100644 packages/core/test/bundling/util/BUILD.bazel delete mode 100644 packages/core/test/bundling/util/src/reflect_metadata.ts diff --git a/packages/core/test/bundling/animation_world/BUILD.bazel b/packages/core/test/bundling/animation_world/BUILD.bazel index 8ad0a1b02afc9..4dc14f36eefc1 100644 --- a/packages/core/test/bundling/animation_world/BUILD.bazel +++ b/packages/core/test/bundling/animation_world/BUILD.bazel @@ -7,7 +7,6 @@ ng_module( srcs = ["index.ts"], deps = [ "//packages/core", - "//packages/core/test/bundling/util:reflect_metadata", "//packages/platform-browser", ], ) diff --git a/packages/core/test/bundling/animation_world/index.ts b/packages/core/test/bundling/animation_world/index.ts index 81e0d77431129..90ba43cc5d736 100644 --- a/packages/core/test/bundling/animation_world/index.ts +++ b/packages/core/test/bundling/animation_world/index.ts @@ -6,8 +6,6 @@ * found in the LICENSE file at https://angular.io/license */ -import '@angular/core/test/bundling/util/src/reflect_metadata'; - import {ApplicationRef, Component, Directive, ElementRef, HostBinding, HostListener, NgModule, ɵdetectChanges as detectChanges} from '@angular/core'; import {BrowserModule, platformBrowser} from '@angular/platform-browser'; diff --git a/packages/core/test/bundling/todo/BUILD.bazel b/packages/core/test/bundling/todo/BUILD.bazel index 579e4c650aad1..81d614f9c2fbd 100644 --- a/packages/core/test/bundling/todo/BUILD.bazel +++ b/packages/core/test/bundling/todo/BUILD.bazel @@ -9,7 +9,6 @@ ng_module( deps = [ "//packages/common", "//packages/core", - "//packages/core/test/bundling/util:reflect_metadata", "//packages/platform-browser", "//packages/platform-browser-dynamic", ], @@ -22,7 +21,6 @@ app_bundle( ":todo", "//packages/common", "//packages/core", - "//packages/core/test/bundling/util:reflect_metadata", "//packages/platform-browser", "//packages/platform-browser-dynamic", "@npm//rxjs", diff --git a/packages/core/test/bundling/todo/index.ts b/packages/core/test/bundling/todo/index.ts index 5d2f848c90de2..7815d24d45621 100644 --- a/packages/core/test/bundling/todo/index.ts +++ b/packages/core/test/bundling/todo/index.ts @@ -6,8 +6,6 @@ * found in the LICENSE file at https://angular.io/license */ -import '@angular/core/test/bundling/util/src/reflect_metadata'; - import {CommonModule} from '@angular/common'; import {Component, Injectable, NgModule} from '@angular/core'; import {BrowserModule, platformBrowser} from '@angular/platform-browser'; diff --git a/packages/core/test/bundling/todo_i18n/BUILD.bazel b/packages/core/test/bundling/todo_i18n/BUILD.bazel index aa496b09d863a..17868056055f6 100644 --- a/packages/core/test/bundling/todo_i18n/BUILD.bazel +++ b/packages/core/test/bundling/todo_i18n/BUILD.bazel @@ -10,7 +10,6 @@ ng_module( ], deps = [ "//packages/core", - "//packages/core/test/bundling/util:reflect_metadata", "//packages/localize", "//packages/localize/init", "//packages/platform-browser", @@ -24,7 +23,6 @@ app_bundle( ":todo_i18n", "//packages/common", "//packages/core", - "//packages/core/test/bundling/util:reflect_metadata", "@npm//rxjs", ], ) diff --git a/packages/core/test/bundling/todo_i18n/index.ts b/packages/core/test/bundling/todo_i18n/index.ts index dabc37462b685..432b7a1c1f7de 100644 --- a/packages/core/test/bundling/todo_i18n/index.ts +++ b/packages/core/test/bundling/todo_i18n/index.ts @@ -5,7 +5,6 @@ * Use of this source code is governed by an MIT-style license that can be * found in the LICENSE file at https://angular.io/license */ -import '@angular/core/test/bundling/util/src/reflect_metadata'; import {Component, Injectable, NgModule, ViewEncapsulation, ɵdetectChanges as detectChanges} from '@angular/core'; import {loadTranslations} from '@angular/localize'; diff --git a/packages/core/test/bundling/util/BUILD.bazel b/packages/core/test/bundling/util/BUILD.bazel deleted file mode 100644 index fbe4284e0bb8c..0000000000000 --- a/packages/core/test/bundling/util/BUILD.bazel +++ /dev/null @@ -1,14 +0,0 @@ -load("//tools:defaults.bzl", "ts_library") - -package(default_visibility = ["//visibility:public"]) - -# Either loads reflect-metadata or is a no-op, depending on whether compilation is in JIT mode. -ts_library( - name = "reflect_metadata", - srcs = [ - "src/reflect_metadata.ts", - ], - module_name = "@angular/core/test/bundling/util/src/reflect_metadata", - module_root = "src/reflect_metadata", - deps = ["@npm//reflect-metadata"], -) diff --git a/packages/core/test/bundling/util/src/reflect_metadata.ts b/packages/core/test/bundling/util/src/reflect_metadata.ts deleted file mode 100644 index ea07f1759b18c..0000000000000 --- a/packages/core/test/bundling/util/src/reflect_metadata.ts +++ /dev/null @@ -1,9 +0,0 @@ -/** - * @license - * Copyright Google LLC All Rights Reserved. - * - * Use of this source code is governed by an MIT-style license that can be - * found in the LICENSE file at https://angular.io/license - */ - -export const UNUSED = true;