Rewrite ngram implementation with an eye for cpp11 performance #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ended up doing a full rewrite so you can see what I did to directly fill the output vector on each ngram iteration rather than creating and returning a temporary vector each time. And so you can see the style i use for C++
It is probably "good enough" for now, but will get better when r-lib/cpp11#299 is fixed
Knowing when to
unwind_protect()
and when to avoid expensive (but safe) cpp11 wrappers does make this pretty challenging to get right.With CRAN cpp11 (0.4.3)
With r-lib/cpp11#299, where the nested
unwind_protect()
bug is fixed: