Clean up the build logs by addressing warnings

[aaravpandya]

The current build logs shows a lot of warnings that may put users at unease. This PR addresses all the warnings in our codebase and adds a flag to suppress all warnings from external repos like Madrona and Json.

[daphne-cornelisse]

Nice! I think this makes sense

• Could you paste the message here to show what it looks like with your changes?
• Can you think of any disadvantages of suppressing these warnings?

[daphne-cornelisse]

Also, can you open the PRs from/to dev? We will merge all changes to main later with release v04

[aaravpandya]

So after you build, there should not be any warnings appearing. Because I fixed all warnings in our code, and suppressed warnings from madrona.
It should look like this -

[  0%] Building CXX object external/madrona/src/common/CMakeFiles/madrona_err.dir/crash.cpp.o
[  1%] Generating ../../../../vk/libvulkan.so.1
[  2%] Building CXX object external/madrona/external/meshoptimizer/CMakeFiles/meshoptimizer.dir/src/allocator.cpp.o
[  2%] Building CXX object external/madrona/external/simdjson/CMakeFiles/simdjson.dir/src/simdjson.cpp.o
[  2%] Building CXX object external/madrona/external/CMakeFiles/spv_reflect.dir/SPIRV-Reflect/spirv_reflect.cpp.o
[  2%] Building CXX object external/madrona/external/meshoptimizer/CMakeFiles/meshoptimizer.dir/src/clusterizer.cpp.o
[  3%] Building CXX object external/madrona/external/meshoptimizer/CMakeFiles/meshoptimizer.dir/src/indexcodec.cpp.o
[  4%] Building CXX object external/madrona/external/meshoptimizer/CMakeFiles/meshoptimizer.dir/src/indexgenerator.cpp.o
[  4%] Generating dispatch/dispatch.template
[  5%] Building CXX object external/madrona/external/meshoptimizer/CMakeFiles/meshoptimizer.dir/src/overdrawoptimizer.cpp.o
[  5%] Generating ../../../../libdxcompiler.so
[  6%] Building CXX object external/madrona/external/meshoptimizer/CMakeFiles/meshoptimizer.dir/src/simplifier.cpp.o
[  6%] Building CXX object external/madrona/external/meshoptimizer/CMakeFiles/meshoptimizer.dir/src/spatialorder.cpp.o
[  9%] Building C object external/madrona/external/glfw/src/CMakeFiles/glfw.dir/context.c.o
[  9%] Building CXX object src/CMakeFiles/nanobind-static.dir/__/external/madrona/external/nanobind/src/nb_internals.cpp.o
[  9%] Building CXX object src/CMakeFiles/nanobind-static.dir/__/external/madrona/external/nanobind/src/nb_type.cpp.o
[  9%] Building CXX object src/CMakeFiles/nanobind-static.dir/__/external/madrona/external/nanobind/src/nb_func.cpp.o
[ 11%] Building CXX object external/madrona/external/meshoptimizer/CMakeFiles/meshoptimizer.dir/src/stripifier.cpp.o
[ 10%] Building CXX object external/madrona/external/meshoptimizer/CMakeFiles/meshoptimizer.dir/src/overdrawanalyzer.cpp.o
[ 13%] Building C object external/madrona/external/glfw/src/CMakeFiles/glfw.dir/init.c.o
[ 13%] Building CXX object src/CMakeFiles/nanobind-static.dir/__/external/madrona/external/nanobind/src/nb_enum.cpp.o
[ 13%] Building CXX object external/madrona/external/meshoptimizer/CMakeFiles/meshoptimizer.dir/src/vcacheanalyzer.cpp.o
[ 13%] Building C object external/madrona/external/glfw/src/CMakeFiles/glfw.dir/input.c.o
[ 13%] Building CXX object src/CMakeFiles/nanobind-static.dir/__/external/madrona/external/nanobind/src/nb_ndarray.cpp.o
[ 13%] Building CXX object external/madrona/external/googletest/googletest/CMakeFiles/gtest.dir/src/gtest-all.cc.o
[ 15%] Building CXX object external/madrona/external/meshoptimizer/CMakeFiles/meshoptimizer.dir/src/vcacheoptimizer.cpp.o
[ 16%] Building CXX object src/CMakeFiles/nanobind-static.dir/__/external/madrona/external/nanobind/src/nb_static_property.cpp.o
[ 17%] Building CXX object src/CMakeFiles/nanobind-static.dir/__/external/madrona/external/nanobind/src/common.cpp.o
[ 17%] Building CXX object src/CMakeFiles/nanobind-static.dir/__/external/madrona/external/nanobind/src/error.cpp.o
[ 18%] Building CXX object src/CMakeFiles/nanobind-static.dir/__/external/madrona/external/nanobind/src/trampoline.cpp.o
[ 19%] Building C object external/madrona/external/glfw/src/CMakeFiles/glfw.dir/monitor.c.o
[ 19%] Building C object external/madrona/external/glfw/src/CMakeFiles/glfw.dir/platform.c.o
[ 19%] Built target madrona_vk_loader
[ 19%] Building CXX object src/CMakeFiles/nanobind-static.dir/__/external/madrona/external/nanobind/src/implicit.cpp.o
[ 19%] Generating dispatch/dispatch_device_impl.hpp, dispatch/dispatch_device_impl.cpp, dispatch/dispatch_instance_impl.hpp, dispatch/dispatch_instance_impl.cpp
[ 19%] Building CXX object external/madrona/external/meshoptimizer/CMakeFiles/meshoptimizer.dir/src/vertexcodec.cpp.o
[ 20%] Building CXX object external/madrona/external/meshoptimizer/CMakeFiles/meshoptimizer.dir/src/vertexfilter.cpp.o
[ 22%] Building C object external/madrona/external/glfw/src/CMakeFiles/glfw.dir/vulkan.c.o
[ 22%] Built target generate_vk_dispatch
[ 22%] Building CXX object external/madrona/external/meshoptimizer/CMakeFiles/meshoptimizer.dir/src/vfetchanalyzer.cpp.o
[ 23%] Building CXX object external/madrona/external/meshoptimizer/CMakeFiles/meshoptimizer.dir/src/vfetchoptimizer.cpp.o
[ 24%] Building C object external/madrona/external/glfw/src/CMakeFiles/glfw.dir/window.c.o
[ 24%] Building C object external/madrona/external/glfw/src/CMakeFiles/glfw.dir/egl_context.c.o
[ 25%] Building C object external/madrona/external/glfw/src/CMakeFiles/glfw.dir/osmesa_context.c.o
[ 25%] Building C object external/madrona/external/glfw/src/CMakeFiles/glfw.dir/null_init.c.o
[ 26%] Building C object external/madrona/external/glfw/src/CMakeFiles/glfw.dir/null_monitor.c.o
[ 26%] Built target madrona_libdxc_shlib
[ 27%] Building C object external/madrona/external/glfw/src/CMakeFiles/glfw.dir/null_joystick.c.o
[ 27%] Building C object external/madrona/external/glfw/src/CMakeFiles/glfw.dir/null_window.c.o
[ 27%] Building C object external/madrona/external/glfw/src/CMakeFiles/glfw.dir/posix_module.c.o
[ 29%] Building C object external/madrona/external/glfw/src/CMakeFiles/glfw.dir/posix_time.c.o
[ 29%] Building C object external/madrona/external/glfw/src/CMakeFiles/glfw.dir/posix_thread.c.o
[ 30%] Building C object external/madrona/external/glfw/src/CMakeFiles/glfw.dir/x11_init.c.o
[ 30%] Building C object external/madrona/external/glfw/src/CMakeFiles/glfw.dir/x11_monitor.c.o
[ 31%] Building C object external/madrona/external/glfw/src/CMakeFiles/glfw.dir/x11_window.c.o
[ 32%] Building C object external/madrona/external/glfw/src/CMakeFiles/glfw.dir/xkb_unicode.c.o
[ 32%] Building C object external/madrona/external/glfw/src/CMakeFiles/glfw.dir/glx_context.c.o
[ 32%] Building C object external/madrona/external/glfw/src/CMakeFiles/glfw.dir/posix_poll.c.o
[ 33%] Building C object external/madrona/external/glfw/src/CMakeFiles/glfw.dir/linux_joystick.c.o
[ 34%] Linking CXX static library libmeshoptimizer.a
[ 34%] Built target meshoptimizer
[ 36%] Linking C shared library ../../../../../libglfw.so
[ 36%] Built target glfw
[ 37%] Building CXX object external/madrona/src/viz/CMakeFiles/imgui_impl.dir/__/__/external/imgui/imgui.cpp.o
[ 37%] Building CXX object external/madrona/src/viz/CMakeFiles/imgui_impl.dir/__/__/external/imgui/imgui_draw.cpp.o
[ 38%] Building CXX object external/madrona/src/viz/CMakeFiles/imgui_impl.dir/__/__/external/imgui/imgui_tables.cpp.o
[ 39%] Building CXX object external/madrona/src/viz/CMakeFiles/imgui_impl.dir/__/__/external/imgui/imgui_widgets.cpp.o
[ 40%] Building CXX object external/madrona/src/viz/CMakeFiles/imgui_impl.dir/__/__/external/imgui/backends/imgui_impl_vulkan.cpp.o
[ 40%] Building CXX object external/madrona/src/viz/CMakeFiles/imgui_impl.dir/imgui_impl_glfw.cpp.o
[ 41%] Linking CXX static library libmadrona_err.a
[ 41%] Built target madrona_err
[ 41%] Building CXX object external/madrona/src/common/CMakeFiles/madrona_cuda.dir/cuda_utils.cpp.o
[ 43%] Building CXX object external/madrona/src/common/CMakeFiles/madrona_common.dir/memory.cpp.o
[ 44%] Building CXX object external/madrona/src/common/CMakeFiles/madrona_common.dir/type_tracker.cpp.o
[ 45%] Building CXX object external/madrona/src/common/CMakeFiles/madrona_common.dir/table.cpp.o
[ 45%] Building CXX object external/madrona/src/common/CMakeFiles/madrona_common.dir/stack_alloc.cpp.o
[ 46%] Building CXX object external/madrona/src/common/CMakeFiles/madrona_common.dir/hashmap.cpp.o
[ 46%] Building CXX object external/madrona/src/common/CMakeFiles/madrona_common.dir/virtual.cpp.o
[ 46%] Building CXX object external/madrona/src/common/CMakeFiles/madrona_common.dir/tracing.cpp.o
[ 47%] Linking CXX static library libmadrona_cuda.a
[ 47%] Built target madrona_cuda
[ 47%] Building CXX object external/madrona/src/python/CMakeFiles/madrona_python_utils.dir/utils.cpp.o
[ 48%] Linking CXX static library libspv_reflect.a
[ 48%] Built target spv_reflect
[ 50%] Linking CXX static library libnanobind-static.a
[ 50%] Built target nanobind-static
[ 51%] Building CXX object src/CMakeFiles/madrona_python_bindings.dir/__/external/madrona/src/python/bindings.cpp.o
[ 52%] Linking CXX static library libmadrona_python_utils.a
[ 52%] Built target madrona_python_utils
[ 52%] Linking CXX static library libimgui_impl.a
[ 52%] Built target imgui_impl
[ 52%] Linking CXX static library libmadrona_common.a
[ 52%] Built target madrona_common
[ 52%] Building CXX object external/madrona/src/physics/CMakeFiles/madrona_physics_assets.dir/physics_assets.cpp.o
[ 52%] Building CXX object external/madrona/src/render/shader/CMakeFiles/madrona_render_shader_compiler.dir/compiler.cpp.o
[ 53%] Building CXX object external/madrona/src/physics/CMakeFiles/madrona_physics_assets.dir/mesh_bvh_builder.cpp.o
[ 53%] Building CXX object external/madrona/src/render/vk/CMakeFiles/madrona_render_vk.dir/backend.cpp.o
[ 53%] Building CXX object external/madrona/src/core/CMakeFiles/madrona_mw_core.dir/state.cpp.o
[ 54%] Building CXX object external/madrona/src/render/vk/CMakeFiles/madrona_render_vk.dir/dispatch.cpp.o
[ 54%] Building CXX object external/madrona/src/render/vk/CMakeFiles/madrona_render_vk.dir/device.cpp.o
[ 55%] Building CXX object external/madrona/src/core/CMakeFiles/madrona_mw_core.dir/context.cpp.o
[ 55%] Building CXX object external/madrona/src/core/CMakeFiles/madrona_mw_core.dir/base.cpp.o
[ 55%] Building CXX object external/madrona/src/render/vk/CMakeFiles/madrona_render_vk.dir/pipeline_shaders.cpp.o
[ 56%] Building CXX object external/madrona/src/core/CMakeFiles/madrona_mw_core.dir/taskgraph.cpp.o
[ 58%] Building CXX object external/madrona/src/render/vk/CMakeFiles/madrona_render_vk.dir/memory.cpp.o
[ 58%] Building CXX object external/madrona/src/render/vk/CMakeFiles/madrona_render_vk.dir/descriptors.cpp.o
[ 59%] Building CXX object external/madrona/src/render/vk/CMakeFiles/madrona_render_vk.dir/utils.cpp.o
[ 60%] Linking CXX static library libsimdjson.a
[ 60%] Built target simdjson
[ 60%] Building CXX object external/madrona/src/importer/CMakeFiles/madrona_json.dir/json.cpp.o
[ 60%] Built target madrona_python_bindings
[ 61%] Linking CXX shared library ../../../../../libmadrona_render_shader_compiler.so
[ 61%] Linking CXX static library ../../../../../lib/libgtest.a
[ 61%] Built target madrona_render_shader_compiler
[ 61%] Built target gtest
[ 62%] Building CXX object external/madrona/external/googletest/googletest/CMakeFiles/gtest_main.dir/src/gtest_main.cc.o
[ 62%] Linking CXX static library libmadrona_physics_assets.a
[ 62%] Built target madrona_physics_assets
[ 63%] Building CXX object external/madrona/src/physics/CMakeFiles/madrona_physics_loader.dir/physics_loader.cpp.o
[ 63%] Linking CXX static library libmadrona_mw_core.a
[ 63%] Built target madrona_mw_core
[ 65%] Building CXX object external/madrona/src/render/CMakeFiles/madrona_rendering_system.dir/ecs_system.cpp.o
[ 66%] Building CXX object external/madrona/src/physics/CMakeFiles/madrona_mw_physics.dir/physics.cpp.o
[ 67%] Building CXX object external/madrona/src/physics/CMakeFiles/madrona_mw_physics.dir/narrowphase.cpp.o
[ 67%] Building CXX object external/madrona/src/physics/CMakeFiles/madrona_mw_physics.dir/geo.cpp.o
[ 67%] Building CXX object external/madrona/src/physics/CMakeFiles/madrona_mw_physics.dir/broadphase.cpp.o
[ 68%] Building CXX object external/madrona/src/physics/CMakeFiles/madrona_mw_physics.dir/xpbd.cpp.o
[ 68%] Building CXX object external/madrona/src/physics/CMakeFiles/madrona_mw_physics.dir/tgs.cpp.o
[ 69%] Building CXX object external/madrona/src/mw/CMakeFiles/madrona_mw_cpu.dir/cpu_exec.cpp.o
[ 70%] Linking CXX static library libmadrona_render_vk.a
[ 70%] Built target madrona_render_vk
[ 72%] Building CXX object external/madrona/src/render/vk/CMakeFiles/madrona_render_vk_cuda.dir/cuda_interop.cpp.o
[ 73%] Linking CXX static library libmadrona_json.a
[ 73%] Built target madrona_json
[ 74%] Building CXX object external/madrona/src/importer/CMakeFiles/madrona_importer.dir/gltf.cpp.o
[ 74%] Building CXX object external/madrona/src/importer/CMakeFiles/madrona_importer.dir/importer.cpp.o
[ 74%] Building CXX object external/madrona/src/importer/CMakeFiles/madrona_importer.dir/obj.cpp.o
[ 75%] Building CXX object external/madrona/src/mw/CMakeFiles/madrona_mw_gpu.dir/cpp_compile.cpp.o
[ 75%] Building CXX object external/madrona/src/mw/CMakeFiles/madrona_mw_gpu.dir/cuda_compile_helpers.cpp.o
[ 75%] Building CXX object external/madrona/src/mw/CMakeFiles/madrona_mw_gpu.dir/ext_gpu_mem.cpp.o
[ 76%] Building CXX object external/madrona/src/mw/CMakeFiles/madrona_mw_gpu.dir/cuda_exec.cpp.o
[ 76%] Linking CXX static library libmadrona_physics_loader.a
[ 76%] Built target madrona_physics_loader
[ 76%] Linking CXX static library libmadrona_mw_cpu.a
[ 76%] Built target madrona_mw_cpu
[ 76%] Linking CXX static library ../../../../../lib/libgtest_main.a
[ 76%] Built target gtest_main
[ 77%] Linking CXX static library libmadrona_mw_physics.a
[ 77%] Built target madrona_mw_physics
[ 77%] Linking CXX static library libmadrona_render_vk_cuda.a
[ 77%] Built target madrona_render_vk_cuda
[ 77%] Linking CXX static library libmadrona_rendering_system.a
[ 77%] Built target madrona_rendering_system
[ 77%] Building CXX object src/CMakeFiles/gpudrive_cpu_impl.dir/sim.cpp.o
[ 79%] Building CXX object src/CMakeFiles/gpudrive_cpu_impl.dir/level_gen.cpp.o
[ 80%] Linking CXX static library libmadrona_importer.a
[ 80%] Built target madrona_importer
[ 80%] Building CXX object external/madrona/src/render/CMakeFiles/madrona_render_core.dir/render_mgr.cpp.o
[ 81%] Building CXX object external/madrona/src/render/CMakeFiles/madrona_render_core.dir/render_ctx.cpp.o
[ 81%] Building CXX object external/madrona/src/render/CMakeFiles/madrona_render_core.dir/image_util.cpp.o
[ 82%] Building CXX object external/madrona/src/render/CMakeFiles/madrona_render_core.dir/batch_renderer.cpp.o
[ 83%] Linking CXX static library libgpudrive_cpu_impl.a
[ 83%] Built target gpudrive_cpu_impl
[ 84%] Linking CXX static library libmadrona_mw_gpu.a
[ 84%] Built target madrona_mw_gpu
[ 86%] Linking CXX static library libmadrona_render_core.a
[ 86%] Built target madrona_render_core
[ 86%] Building CXX object external/madrona/src/render/CMakeFiles/madrona_render.dir/api.cpp.o
[ 87%] Linking CXX static library libmadrona_render.a
[ 87%] Built target madrona_render
[ 87%] Building CXX object src/CMakeFiles/gpudrive_mgr.dir/mgr.cpp.o
[ 88%] Building CXX object src/CMakeFiles/gpudrive_mgr.dir/MapReader.cpp.o
[ 88%] Building CXX object external/madrona/src/interact/CMakeFiles/madrona_window.dir/window.cpp.o
[ 89%] Linking CXX static library libmadrona_window.a
[ 89%] Built target madrona_window
[ 90%] Building CXX object external/madrona/src/viz/CMakeFiles/madrona_viz.dir/viewer.cpp.o
[ 91%] Building CXX object external/madrona/src/viz/CMakeFiles/madrona_viz.dir/present.cpp.o
[ 91%] Building CXX object external/madrona/src/viz/CMakeFiles/madrona_viz.dir/viewer_renderer.cpp.o
[ 91%] Linking CXX static library libmadrona_viz.a
[ 91%] Built target madrona_viz
[ 91%] Linking CXX static library libgpudrive_mgr.a
[ 91%] Built target gpudrive_mgr
[ 91%] Building CXX object src/CMakeFiles/gpudrive.dir/bindings.cpp.o
[ 94%] Building CXX object src/CMakeFiles/headless.dir/headless.cpp.o
[ 94%] Building CXX object src/CMakeFiles/viewer.dir/viewer.cpp.o
[ 94%] Building CXX object tests/CMakeFiles/my_tests.dir/bicyclemodel.cpp.o
[ 95%] Building CXX object tests/CMakeFiles/my_tests.dir/CollisionDetectionTests.cpp.o
[ 95%] Building CXX object tests/CMakeFiles/my_tests.dir/test_utils.cpp.o
[ 96%] Building CXX object tests/CMakeFiles/my_tests.dir/observationTest.cpp.o
[ 96%] Building CXX object tests/CMakeFiles/my_tests.dir/EgocentricRoadObservationTests.cpp.o
[ 97%] Linking CXX executable ../viewer
[ 97%] Built target viewer
[ 97%] Linking CXX executable ../headless
[ 97%] Built target headless
[ 98%] Linking CXX shared module ../gpudrive.cpython-311-x86_64-linux-gnu.so
[ 98%] Built target gpudrive
[100%] Linking CXX executable my_tests
[100%] Built target my_tests
Installing the current project: gpudrive (0.1.0)

[aaravpandya]

There are no disadvantages. If you add some code, the warnings can still appear from that code as we dont suppress the code from our code base.

If there are warnings in madrona for eg, then its more than likely you are diving very deep to find some problem in madrona. In that case, the dev would probably be working with madrona directly.