Sim level z-axis integration #270
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-joseph-ai
force-pushed
the
feat/z-axis
branch
from
d0adedf to
898e861
Compare
kevin-joseph-ai
force-pushed
the
feat/z-axis
branch
from
dba2c59 to
d1a1b46
Compare
Collaborator
Author
|
TODO:
|
kevin-joseph-ai
force-pushed
the
feat/z-axis
branch
from
a426211 to
98f82f1
Compare
| bool IgnoreNonVehicles = false; // Default: false | ||
| FindRoadObservationsWith roadObservationAlgorithm{ | ||
| FindRoadObservationsWith::KNearestEntitiesWithRadiusFiltering}; | ||
| FindRoadObservationsWith::AllEntitiesWithRadiusFiltering}; |
Contributor
There was a problem hiding this comment.
probably do not want this change to do this?
Contributor
There was a problem hiding this comment.
Yeah I think this branch contains a lot of changes we do not want to include. I am starting a different branch with only the minimal required changes to access the z logs
| { | ||
| p.x = j.at("x").get<float>(); | ||
| p.y = j.at("y").get<float>(); | ||
| if (j.contains("z")) { |
Contributor
There was a problem hiding this comment.
does it sometimes not contain it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simulator changes to accommodate z axis.