Updated erpc_python/setup.py #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix premature import of package, causing failure when attempting
installation of Python library in a clean environment.
|
Hi, thank you for your contribution. Could you change destination branch to develop. |
|
Done. |
Hadatko
approved these changes
Jan 11, 2022
Apply review suggestion: initialize ERPC_VERSION to None
Hadatko
approved these changes
Jan 12, 2022
There was a problem hiding this comment.
Thank you very much that you are still active, this should be merge soon if @MichalPrincNXP will agree.
MichalPrincNXP
approved these changes
Jan 18, 2022
|
Thank you for the effort and the patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated
erpc_python/setup.py. Remove import of theerpc_versionsubmodule, causing execution of the package initialization script, pulling another submodules and in consequence causing failure of package installation in a clean Python environment. Instead of usingimportfeature, open theerpc_version.pyfile directly in execute it, causingERPC_VERSIONconstant to be available directly in the namespace whensetupfunction is being executed.Related Issue
Resolves #37