Skip to content

Conversation

Hadatko
Copy link
Member

@Hadatko Hadatko commented Aug 29, 2023

Pull request

Choose Correct

  • bug
  • feature

Describe the pull request

This PR is moving enums from global scope to class scope.

To Reproduce

Expected behavior

Screenshots

Desktop (please complete the following information):

  • OS:
  • eRPC Version:

Steps you didn't forgot to do

  • I checked if other PR isn't solving this issue.
  • I read Contribution details and did appropriate actions.
  • PR code is tested.
  • PR code is formatted.
  • Allow edits from maintainers pull request option is set (recommended).

Additional context

Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
@Hadatko Hadatko self-assigned this Aug 29, 2023
@Hadatko Hadatko added this to the 1.12.0 milestone Aug 29, 2023
@Hadatko Hadatko requested a review from MichalPrincNXP August 29, 2023 18:12
@Hadatko
Copy link
Member Author

Hadatko commented Sep 18, 2023

@MichalPrincNXP i think this is ready to merge. Can you review it?

@Hadatko Hadatko closed this Sep 18, 2023
@Hadatko Hadatko reopened this Sep 18, 2023
@Hadatko
Copy link
Member Author

Hadatko commented Sep 18, 2023

Closed by mistake ;) @MichalPrincNXP waiting for review

Copy link
Member

@MichalPrincNXP MichalPrincNXP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performed on-board testing and all seems to be ok.

@MichalPrincNXP MichalPrincNXP merged commit f6d9011 into EmbeddedRPC:develop Sep 19, 2023
@MichalPrincNXP
Copy link
Member

Thank you.

@Hadatko Hadatko deleted the feature/EnumClassInLib branch September 19, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants