Skip to content

Conversation

amgross
Copy link
Contributor

@amgross amgross commented Aug 10, 2023

Pull request

Choose Correct

  • bug
  • feature

Describe the pull request

There is typo where the null is checked against the assert instead of in the assert
To Reproduce

Expected behavior

Screenshots

Desktop (please complete the following information):

  • OS:
  • eRPC Version:

Steps you didn't forgot to do

  • I checked if other PR isn't solving this issue.
  • I read Contribution details and did appropriate actions.
  • PR code is tested.
  • PR code is formatted.
  • Allow edits from maintainers pull request option is set (recommended).

Additional context

@Hadatko Hadatko added this to the 1.12.0 milestone Aug 10, 2023
@Hadatko Hadatko added the bug label Aug 10, 2023
@Hadatko
Copy link
Member

Hadatko commented Aug 10, 2023

Hi. Nice catch. I will merge this immediately. Thank you

@Hadatko Hadatko merged commit b3951d8 into EmbeddedRPC:develop Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants