Skip to content

Conversation

Hadatko
Copy link
Member

@Hadatko Hadatko commented Jan 9, 2023

Pull request

Choose Correct

  • bug
  • feature

Describe the pull request

Depends on #334.
This PR enables MacOS target

To Reproduce

Expected behavior

Screenshots

Desktop (please complete the following information):

  • OS:
  • eRPC Version:

Steps you didn't forgot to do

  • I checked if other PR isn't solving this issue.
  • I read Contribution details and did appropriate actions.
  • PR code is tested.
  • PR code is formatted.
  • Allow edits from maintainers pull request option is set (recommended).

Additional context

Hadatko and others added 4 commits January 6, 2023 16:25
Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
@Hadatko Hadatko added this to the 1.11.0 milestone Jan 9, 2023
@Hadatko Hadatko requested a review from MichalPrincNXP January 9, 2023 11:27
@Hadatko Hadatko self-assigned this Jan 9, 2023
Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
@Hadatko
Copy link
Member Author

Hadatko commented Jan 9, 2023

@MichalPrincNXP This PR looks also done. Please merge first #334. Then you will get less amount of changes in this one.

@MichalPrincNXP
Copy link
Member

May I ask you to rebase this PR? I was able to do it in #334 but do not see this possibility in this PR.

@MichalPrincNXP
Copy link
Member

Also, would it be possible to involve the #342 bugfix into this PR, please?

Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
@Hadatko
Copy link
Member Author

Hadatko commented Jan 25, 2023

@MichalPrincNXP #342 Partially, but bug is not in our repository but in combination of newer clang and boost libraries. I will try to communicate with boost to let them fix it on their side

@MichalPrincNXP MichalPrincNXP merged commit e5fb9a6 into EmbeddedRPC:develop Jan 26, 2023
@MichalPrincNXP
Copy link
Member

@MichalPrincNXP #342 Partially, but bug is not in our repository but in combination of newer clang and boost libraries. I will try to communicate with boost to let them fix it on their side

OK, thank you

@Hadatko Hadatko deleted the circleci-editor/895/develop branch January 26, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants