Build TCP transport setup code into liberpc #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TCP transport is already included in liberpc, so it makes sense to include the necessary setup code to use that transport from C.
|
Hi, you are correct. Tcp setup file was created recently and author didn't need it in library. So lets approve your PR as it make sense ;) @MichalPrincNXP this is quick one ;) |
MichalPrincNXP
approved these changes
Jun 24, 2021
|
Hello @dpfrey , thank you for this PR. Again, because the internal testing for the v1.8.1 release is almost finished, I would rather integrate this PR after the release, i.e. in about 3w. Thank you. |
|
Thank you @dpfrey for your support! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TCP transport is already included in liberpc, so it makes sense to
include the necessary setup code to use that transport from C.