Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn/error if duplicate is allowed, but unnecessary #725

Closed
sagudev opened this issue Nov 27, 2024 · 1 comment · Fixed by #726
Closed

Warn/error if duplicate is allowed, but unnecessary #725

sagudev opened this issue Nov 27, 2024 · 1 comment · Fixed by #726
Labels
enhancement New feature or request

Comments

@sagudev
Copy link

sagudev commented Nov 27, 2024

Is your feature request related to a problem? Please describe.
We want to replace servo's python lints with cargo-deny, but this is only thing that is missing.

Describe the solution you'd like
Detect when a duplicate versions are allowed, but not present. This is useful to keep the list clean.

Describe alternatives you've considered
Do nothing.

Additional context
Issue in servo: servo/servo#34393
related code in servo: https://github.com/servo/servo/blob/d65a2e97970cbc3900c7f62e1c51776710623887/python/tidy/tidy.py#L375

@sagudev sagudev added the enhancement New feature or request label Nov 27, 2024
Jake-Shadle added a commit that referenced this issue Nov 28, 2024
- **Update rustls and url**
- **Update gix and tame-index**
- **Add unnecessary-skip diagnostic**

Resolves: #725
@Jake-Shadle
Copy link
Member

FWIW, though I fixed this bug, personally I always use exact version specifiers, as most of the time, skips are temporary when crate used transitively has done a non-patch release and it takes time for all dependencies to use the newer version, so when they all have the skip will no longer match the older version, and it will give an error if another version is somehow used in the graph during that time, unlike using just the crate name, which will match all versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants