Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: EmbarkStudios/cargo-deny
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.13.9
Choose a base ref
...
head repository: EmbarkStudios/cargo-deny
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.14.0
Choose a head ref
  • 16 commits
  • 64 files changed
  • 6 contributors

Commits on May 23, 2023

  1. Update audits & exemptions

    New state:
    `Vetting Succeeded (67 fully audited, 45 partially audited, 157 exempted)`
    repi committed May 23, 2023
    Configuration menu
    Copy the full SHA
    c214b7b View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2023

  1. Configuration menu
    Copy the full SHA
    dc6c8f4 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. Add trusted crate publishers (#517)

    Similar to how we've done in a few of our other reviews, so we can focus on audits of more unknown crates and publishers.
    
    Also excluded auditing for a few additional crates that are not used in practice (unsupported/unused targets).
    
    Current audit state:
    
    `Vetting Succeeded (136 fully audited, 26 partially audited, 107 exempted)`
    repi authored Jun 8, 2023
    Configuration menu
    Copy the full SHA
    14b6232 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. Only ignore root-level target directory (#516)

    Reason: When running `cargo vendor`, some of the dependencies have
    "target" directories that should *not* be ignored: platforms-3.0.2 and cargo-0.69.1
    jfgoog authored Jun 13, 2023
    Configuration menu
    Copy the full SHA
    e69ceb8 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. Configuration menu
    Copy the full SHA
    9ca5722 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Fix typo in deny.template.toml (#527)

    Project linter can be triggered - this PR fixes it.
    oriontvv authored Jul 11, 2023
    Configuration menu
    Copy the full SHA
    b8634ce View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Nuke git2 + openssl (#520)

    This is a massive refactor that should be split up into multiple PRs,
    but I am lazy, so that won't happen.
    
    ## `crates-index` -> `tame-index`
    
    The `crates-index` crate had a problematic API that lead to duplicating
    functionality present in the crate because it wasn't exposed publicly,
    and was actually causing massive slowdowns when running cargo-deny in
    eg. CI since `krates` was downloading the entire git index because of
    how the default functionality in `crates-index` worked, thus I made
    [`tame-index`](https://github.com/EmbarkStudios/tame-index) to better
    suit the needs of this crate, as well as
    [`cargo-fetcher`](https://github.com/EmbarkStudios/cargo-fetcher). Also,
    it is now unfortunately
    [unmaintained](frewsxcv/rust-crates-index#132).
    
    This also means that scenarios such as #515 are _much_ easier to both
    implement and support due to better testing since `tame-index` supports
    [local
    registry](https://doc.rust-lang.org/cargo/reference/source-replacement.html#local-registry-sources)
    source replacement.
    
    ## `git2` -> `gix`
    
    `tame-index` uses `gix` for its git implementation because
    git2/openssl/openssh are...let's just say I'm not a fan. This PR now
    replaces the usage of `git2`, for syncing advisory databases, with `gix`
    removing (and adding) a lot of dependencies.
    
    Resolves: #361
    Resolves: #515
    Resolves: #522
    Resolves: #446 (I think this was already resolved in a previous version,
    but the issue was still open)
    Resolves: #435 (I have no idea if this is actually fixed, but I have no
    repro, and we aren't using git2 any longer, so maybe?)
    Resolves: #439 (I was never able to repro, but this is no longer
    applicable as we never fetch a specific branch for a git remote for
    either advisory databases nor git registry indices, but rather just use
    the remote `FETCH_HEAD`)
    Closes: #295 (This PR removes cargo support altogether, as it is
    currently tied to openssl/curl/etc and not currently worth pursuing)
    Jake-Shadle authored Jul 25, 2023
    Configuration menu
    Copy the full SHA
    6687be7 View commit details
    Browse the repository at this point in the history
  2. Add osi and fsf values for allow-osi-fsf-free config (#531)

    This PR resolves #210 by adding `osi` and `fsf` as new values for
    `allow-osi-fsf-free`. This allows for the use case where a cargo-deny
    user wants to blanket allow all FSF licenses while not caring about OSI
    (or vice versa).
    zkxs authored Jul 25, 2023
    Configuration menu
    Copy the full SHA
    dbba1dc View commit details
    Browse the repository at this point in the history
  3. Fix license cfg test

    Jake-Shadle committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    41d54d3 View commit details
    Browse the repository at this point in the history
  4. Fix a mistake made in #531 (#532)

    I had initially patterned the new license checks on `OsiOnly` and
    `FsfOnly` before realizing that perhaps deny!() didn't make sense here,
    and I removed it (or so I thought). It seems I blundered and left one
    in--sorry.
    
    I believe this deny!() shouldn't be here.
    
    Apologies for the mistake... I thought I'd double-checked my diff but it
    seems I did a poor job of it.
    
    (Also, thanks for catching that other mistake I made in #531 Jake)
    zkxs authored Jul 25, 2023
    Configuration menu
    Copy the full SHA
    2a59de4 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Fixup license clarifications (#533)

    - Fixup license clarification
    - Add clarification example
    - Add test
    
    Resolves: #521 
    Resolves: #524
    Jake-Shadle authored Jul 26, 2023
    Configuration menu
    Copy the full SHA
    3fce203 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. Improve advisory db fetching (#534)

    This fixes a few issues with advisory dbs, notably ensuring they can be
    fetched regardless of the environment, writing `FETCH_HEAD` via
    https://docs.rs/tame-index/0.2.4/tame_index/utils/git/fn.write_fetch_head.html,
    and properly locking repos before opening/cloning.
    
    Resolves: #479
    Jake-Shadle authored Jul 28, 2023
    Configuration menu
    Copy the full SHA
    169a70a View commit details
    Browse the repository at this point in the history
  2. Add/improve cargo update messages (#535)

    Fixup #523
    
    Resolves: #482
    Jake-Shadle authored Jul 28, 2023
    Configuration menu
    Copy the full SHA
    bf21207 View commit details
    Browse the repository at this point in the history
  3. Prepare release (#536)

    - Cleanup docs
    - Update CHANGELOG
    Jake-Shadle authored Jul 28, 2023
    Configuration menu
    Copy the full SHA
    1269021 View commit details
    Browse the repository at this point in the history
  4. update README

    Jake-Shadle committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    4cc0f39 View commit details
    Browse the repository at this point in the history
  5. Release 0.14.0

    Jake-Shadle committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    98a8b2f View commit details
    Browse the repository at this point in the history
Loading