Refactor.

Simplification of the structure.

Author: Krabaton

app.js

@@ -2,17 +2,17 @@ const express = require('express')
 const logger = require('morgan')
 const cors = require('cors')
 
-const indexRouter = require('./routes/index')
+const contactsRouter = require('./routes/api/contacts')
 
 const app = express()
 
-const formatsLogger = app.get('env') === 'development' ? 'dev' : 'combined'
+const formatsLogger = app.get('env') === 'development' ? 'dev' : 'short'
 
 app.use(logger(formatsLogger))
 app.use(cors())
 app.use(express.json())
 
-app.use('/api/contacts', indexRouter)
+app.use('/api/contacts', contactsRouter)
 
 app.use((req, res) => {
   res.status(404).json({ message: 'Not found' })

bin/server.js

@@ -1,53 +1,7 @@
-#!/usr/bin/env node
-
 const app = require('../app')
-const debug = require('debug')('template:server')
-const http = require('http')
-
-const normalizePort = (val) => {
-  const port = parseInt(val, 10)
-
-  if (isNaN(port)) {
-    return val
-  }
-
-  if (port >= 0) {
-    return port
-  }
-
-  return false
-}
-
-const port = normalizePort(process.env.PORT || '3000')
-app.set('port', port)
-
-const server = http.createServer(app)
-
-server.listen(port)
-server.on('error', onError)
-server.on('listening', onListening)
-
-function onError(error) {
-  if (error.syscall !== 'listen') {
-    throw error
-  }
-
-  const bind = typeof port === 'string' ? 'Pipe ' + port : 'Port ' + port
 
-  switch (error.code) {
-    case 'EACCES':
-      console.error(bind + ' requires elevated privileges')
-      process.exit(1)
-    case 'EADDRINUSE':
-      console.error(bind + ' is already in use')
-      process.exit(1)
-    default:
-      throw error
-  }
-}
+const PORT = process.env.PORT || 3000
 
-function onListening() {
-  const addr = server.address()
-  const bind = typeof addr === 'string' ? 'pipe ' + addr : 'port ' + addr.port
-  debug('Listening on ' + bind)
-}
+app.listen(PORT, () => {
+  console.log(`Server running. Use our API on port: ${PORT}`)
+})

package.json

@@ -4,15 +4,13 @@
   "private": true,
   "scripts": {
     "start": "cross-env NODE_ENV=production node ./bin/server.js",
-    "start:dev": "nodemon ./bin/server.js",
-    "start:debug": "cross-env DEBUG=* nodemon ./bin/server.js",
+    "start:dev": "cross-env NODE_ENV=development nodemon ./bin/server.js",
     "lint": "eslint **/*.js",
     "lint:fix": "eslint --fix **/*.js"
   },
   "dependencies": {
     "cors": "2.8.5",
     "cross-env": "7.0.3",
-    "debug": "4.3.1",
     "express": "4.17.1",
     "morgan": "1.10.0"
   },

readme.md

@@ -27,6 +27,5 @@
 
 - `npm start` — старт сервера в режиме production
 - `npm run start:dev` — старт сервера в режиме разработки (development)
-- `npm run start:debug` — старт сервера в режиме DEBUG
 - `npm run lint` — запустить выполнение проверки кода с eslint, необходимо выполнять перед каждым PR и исправлять все ошибки линтера
 - `npm lint:fix` — та же проверка линтера, но с автоматическими исправлениями простых ошибок