fix: Raise Error for long TEST_DIR #5703
Conversation
I added an if statment after we define our test dir path to check if it is larger than 12 characters because otherwise it was throwing an error
| if len(d) > 12: | ||
| raise ValueError("TEST_DIR length is too long please create one with less than x characters") |
There was a problem hiding this comment.
do you think that this is a hacky approach?
Maybe the solution is to fix the opts parser?
cc: @javiervargas that is working on a C solution
There was a problem hiding this comment.
ya its a bit hacky would you be able to point me to the opts parser? @javiervargas do you have a branch maybe I could look at?
There was a problem hiding this comment.
is this where I should be looking?
https://github.com/ElementsProject/lightning/blob/master/lightningd/options.c#L1420
|
I've been working on in two possibles solutions. One could be increase this variable (after compile tests worked well)
But here, Maybe rusty could precise if this is a good approach. Or second create a new method that prints arbitrary lenghts. I'm finishing that code. Thanks to @vincenzopalazzo Issue seems to be here. |
|
BTW, I'm closing this. The options parser should now be fixed? |
|
yeah it is alredy fixed |
I added an if statment after we define our test dir path to check if it is larger than 12 characters because otherwise it was throwing an error
this closes: #5576