payalgo: Improve telemetry #1100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Merge of #1012 breaks this due to struct change, will rebase |
rustyrussell
approved these changes
Feb 26, 2018
ZmnSCPxj
force-pushed
the
payalgo-telemetry
branch
from
5a95a5a to
ee2642c
Compare
Contributor
Author
|
Rebased, ready for review again. |
…NION. These error codes will cause `pay` to retry, so `pay` will never actually report those error codes. Those error codes will only get reported at the `sendpay` level.
ZmnSCPxj
force-pushed
the
payalgo-telemetry
branch
from
ee2642c to
469d0ee
Compare
Contributor
Author
|
rebased to get merged-in #1111 |
Member
|
ACK 469d0ee |
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this pull request
Sep 12, 2023
…11: min_final_cltv_expiry_delta is optional, not required (ElementsProject#1100)" Since we changed the default, it used to be required to set it. That was a while ago, though, so we can make it optional again. Changelog-Changed: Protocol: `invoice` no longer explicitly encodes `c` if it's the default (18) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this pull request
Sep 12, 2023
…11: min_final_cltv_expiry_delta is optional, not required (ElementsProject#1100)" Since we changed the default, it used to be required to set it. That was a while ago, though, so we can make it optional again. Changelog-Changed: Protocol: `invoice` no longer explicitly encodes `c` if it's the default (18) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
added a commit
that referenced
this pull request
Sep 20, 2023
…11: min_final_cltv_expiry_delta is optional, not required (#1100)" Since we changed the default, it used to be required to set it. That was a while ago, though, so we can make it optional again. Changelog-Changed: Protocol: `invoice` no longer explicitly encodes `c` if it's the default (18) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this pull request
Sep 20, 2023
…11: min_final_cltv_expiry_delta is optional, not required (ElementsProject#1100)" Since we changed the default, it used to be required to set it. That was a while ago, though, so we can make it optional again. Changelog-Changed: Protocol: `invoice` no longer explicitly encodes `c` if it's the default (18) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users are asking for more information from their failed payments, we should provide it on logs and
payreturn value.