Skip to content

Commit b07d903

Browse files
committed
pyln-testing: fix catching of memleak/broken errors at exit.
Commit 901342b ("pyln-testing: require explicit pattern for BROKEN messages.") changed to a manual scan of logs rather than using is_in_log, so it needs to manually refresh, otherwise we miss final log messages. This causes us to often miss memleak messages, which are printed only in the exit path! Reported-by: Lagrang3 Fixes: #7565 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
1 parent 74c906e commit b07d903

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

contrib/pyln-testing/pyln/testing/fixtures.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -605,6 +605,7 @@ def checkBadGossip(node):
605605

606606

607607
def checkBroken(node):
608+
node.daemon.logs_catchup()
608609
broken_lines = [l for l in node.daemon.logs if '**BROKEN**' in l]
609610
if node.broken_log:
610611
ex = re.compile(node.broken_log)

0 commit comments

Comments
 (0)