gossipd: fix crash in seeker rotation code.

rustyrussell · rustyrussell · commit 9499d5c682cb · 2024-11-28T15:56:05.000+10:30
Reported-by: hMsats Fixes: #7875 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-None: introduced in rc1
diff --git a/gossipd/seeker.c b/gossipd/seeker.c
@@ -904,7 +904,8 @@ static void reset_gossip_performance_metrics(struct seeker *seeker)
 {
 	seeker->new_gossiper_elapsed = 0;
 	for (int i = 0; i < tal_count(seeker->gossiper); i++) {
-		seeker->gossiper[i]->gossip_counter = 0;
+		if (seeker->gossiper[i])
+			seeker->gossiper[i]->gossip_counter = 0;
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -904,7 +904,8 @@ static void reset_gossip_performance_metrics(struct seeker *seeker)`
`904`	`904`	`{`
`905`	`905`	`seeker->new_gossiper_elapsed = 0;`
`906`	`906`	`for (int i = 0; i < tal_count(seeker->gossiper); i++) {`
`907`		`- seeker->gossiper[i]->gossip_counter = 0;`
	`907`	`+ if (seeker->gossiper[i])`
	`908`	`+ seeker->gossiper[i]->gossip_counter = 0;`
`908`	`909`	`}`
`909`	`910`	`}`
`910`	`911`