Make issuance fail for invalid addresses #861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without his change, invalid addresses are converted into fee outputs.
stevenroose
changed the title
Contributor
Author
|
Please also review backport: #867. |
gwillen
reviewed
Apr 16, 2020
| CTxDestination token_address(DecodeDestination(token_address_str)); | ||
| CScript asset_destination = GetScriptForDestination(asset_address); | ||
| CScript token_destination = GetScriptForDestination(token_address); | ||
| CScript asset_script = GetScriptForDestination(asset_dest); |
Contributor
There was a problem hiding this comment.
You don't need to change this now if you don't feel like it, but I think the rename makes the diff a little harder to follow, when there is also code moving and code changing. But maybe that's a dumb thing for me to say, I dunno, good names are important too.
Contributor
Author
There was a problem hiding this comment.
Yeah I could have cut the change into more than one commit. I'd be happy to do that. But I see you ack'ed it.
Contributor
|
utACK 4256916. |
Contributor
|
Looks like the test failure is a timeout, I assume you'll kick it to try again. |
stevenroose
added a commit
that referenced
this pull request
Apr 16, 2020
8e5893e Add test to make sure issuances to wrong addresses fail (Steven Roose) 21b3913 Make issuance fail for invalid addresses (Steven Roose) Pull request description: Backport of #861. Tree-SHA512: 6ef9d50c1b63d93dd3497b38510e8628d02dd876d85b270e3ede4c68118aaf1e7cd3c73ee7f35d7b51cc7500517f3cedd4e0bf5d4de0be373a51ae008d89cf15
stevenroose
pushed a commit
that referenced
this pull request
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #853.