[0.17] Add OptionsCategory::ELEMENTS #453
Conversation
instagibbs
changed the title
|
utACK only test failing is the one that fails to build reliably |
|
Not sure how this category should be applied to the CHAINPARAMS category in chainparams.cpp. Those are also mostly elements-specific. (fedpegscript, blocksignscript, ...) |
|
I say let's add all of them if we're bothering to do any of them, to make it easier to rebase later. |
| // Elements-specific arguments. | ||
| // | ||
|
|
||
| std::vector<std::string> elements_hidden_args = {"-con_fpowallowmindifficultyblocks", "-con_fpownoretargeting", "-con_nsubsidyhalvinginterval", "-con_bip16exception", "-con_bip34height", "-con_bip65height", "-con_bip66height", "-con_npowtargettimespan", "-con_npowtargetspacing", "-con_nrulechangeactivationthreshold", "-con_nminerconfirmationwindow", "-con_powlimit", "-con_bip34hash", "-con_nminimumchainwork", "-con_defaultassumevalid", "-npruneafterheight", "-fdefaultconsistencychecks", "-fmineblocksondemand", "-fallback_fee_enabled", "-pchmessagestart"}; |
There was a problem hiding this comment.
Might be better to add these as debug args.
There was a problem hiding this comment.
The latter can be shown with -help-debug
There was a problem hiding this comment.
Adding them as debug args sounds good to me. Perhaps do the same in bitcoin/bitcoin#8994 ?
There was a problem hiding this comment.
@jtimon If you convert them to debug args upstream, I'd prefer to inherit the exact same wording here.
src/init.cpp
Outdated
|
|
||
| std::vector<std::string> elements_hidden_args = {"-con_fpowallowmindifficultyblocks", "-con_fpownoretargeting", "-con_nsubsidyhalvinginterval", "-con_bip16exception", "-con_bip34height", "-con_bip65height", "-con_bip66height", "-con_npowtargettimespan", "-con_npowtargetspacing", "-con_nrulechangeactivationthreshold", "-con_nminerconfirmationwindow", "-con_powlimit", "-con_bip34hash", "-con_nminimumchainwork", "-con_defaultassumevalid", "-npruneafterheight", "-fdefaultconsistencychecks", "-fmineblocksondemand", "-fallback_fee_enabled", "-pchmessagestart"}; | ||
|
|
||
| gArgs.AddArg("-pubkeyprefix", strprintf("The byte prefix, in decimal, of the chain's base58 pubkey address. (default: %d)", defaultChainParams->Base58Prefix(CChainParams::PUBKEY_ADDRESS)[0]), false, OptionsCategory::ELEMENTS); |
There was a problem hiding this comment.
These look more chainparams specific than elements specific to me.
|
concept ACK (at least for any new parameter not included in bitcoin/bitcoin#8994 ). |
|
I updated the chainparams ones. For the debug ones from testchains, I'm waiting to know if I can inherit the ones from upstream. |
| gArgs.AddArg("-server", "Accept command line and JSON-RPC commands", false, OptionsCategory::RPC); | ||
|
|
||
| // chain params | ||
| gArgs.AddArg("-pubkeyprefix", strprintf("The byte prefix, in decimal, of the chain's base58 pubkey address. (default: %d)", defaultChainParams->Base58Prefix(CChainParams::PUBKEY_ADDRESS)[0]), false, OptionsCategory::CHAINPARAMS); |
There was a problem hiding this comment.
We'll just have to make sure to update defaultChainParams to using Custom Chains instead of MAIN at some point.
|
ACK |
2e4cb70 Mark chain params as ::CHAINPARAMS (Steven Roose) 91e48e7 Sane defaults for CHAINPARAM cli args (Steven Roose) fdf494e Also change Elements-specific chainparams (Steven Roose) 2638df8 Set correct OptionsCategory for elements options (Steven Roose) 6ba4764 Add OptionsCategory::ELEMENTS (Steven Roose) Pull request description: Attempt to group elements-specific -options together. Tree-SHA512: 3cc669c55f657b9d20c4bc2d67d222b73649b916b45f127858f3ca20210f5589a44a0dac508d47007b7f628fc4108f5ee3011a658ff269c47b722270404a4c4f
4 participants
Attempt to group elements-specific -options together.