[0.17] Test: Fix example_test.py #434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
3 tasks
Contributor
|
is this an upstream fix? |
Contributor
|
this was fixed: |
Contributor
|
ACK |
1 similar comment
Contributor
|
ACK |
jtimon
added a commit
that referenced
this pull request
Oct 16, 2018
1f1c7df Test: Fix example_test.py (Jorge Timón) Pull request description: Fix this useful test in -extended. IMO should be backported to bitcoin/0.17, but I'm not sure if it's wanted there. Tree-SHA512: d67c186c3dd59d13ec7c9cc79ae6dfd5a0dbd2ea76a8e3b5eb0020dedd08e004929741ed7b4ac9ca2a30da10b11e73179b0967023f59892eb59cb8d68ca67294
instagibbs
added a commit
that referenced
this pull request
Oct 16, 2018
… tests a1e0c56 QA: Use resgtest2 chain instead of regtest for rpc tests (Jorge Timón) 4454c52 QA: Adapt BitcoinTestFramework for chains other than "regtest" (Jorge Timón) a06be15 Testchains: Introduce custom chain whose constructor... (Jorge Timón) 46749eb Testchains: Qt: Simplify network/chain styles and add a default purple (Jorge Timón) c0c1e38 Testchains: Generic selection with -chain=<str> in addition of -testnet and -regtest (Jorge Timón) 56515c3 9102: Really don't validate genesis block (Gregory Sanders) Pull request description: Backport of bitcoin/bitcoin#8994 The tests seem to pass with: ``` python3 ./test/functional/test_runner.py -j4 --extended ``` Let's please try to keep all general review things on bitcoin/bitcoin#8994 and elements-specific things here. Dependencies: - [x] [0.17] Don't edit Chainparams after initialization #427 - [x] [0.17] Test: Fix example_test.py #434 Tree-SHA512: e216587b6f9d3a462372915e01c8eb3c65a61e4ea29f398e65a7fc03a3ea5676c4711527b5cc2c115893591e7cd5b0ecd2f1fac4faf7ef747a022e2657bc99d4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix this useful test in -extended.
IMO should be backported to bitcoin/0.17, but I'm not sure if it's wanted there.