Skip to content

Conversation

@instagibbs
Copy link
Contributor

@instagibbs instagibbs commented Oct 12, 2018

Tests should now be working.

@instagibbs instagibbs changed the title [WIP] Connect gen block tx to db, don't validate gen block [WIP, 0.17] Connect gen block tx to db, don't validate gen block Oct 12, 2018
@jtimon
Copy link
Contributor

jtimon commented Oct 16, 2018

A rebase should probably make things much clearer.

@jtimon jtimon added the 0.17 label Oct 16, 2018
@instagibbs instagibbs changed the title [WIP, 0.17] Connect gen block tx to db, don't validate gen block [0.17] Connect gen block tx to db, don't validate gen block Oct 23, 2018
@instagibbs instagibbs force-pushed the gen_block branch 2 times, most recently from 0eba762 to 237b4ec Compare October 24, 2018 19:36
@instagibbs
Copy link
Contributor Author

rebased

@stevenroose
Copy link
Contributor

stevenroose commented Oct 25, 2018

tACK 237b4ec

I restarted Travis. It worked for me.

@instagibbs
Copy link
Contributor Author

lint error, rebasing on tip...

@instagibbs instagibbs merged commit d97920c into ElementsProject:elements-0.17 Oct 25, 2018
instagibbs added a commit that referenced this pull request Oct 25, 2018
d97920c add functional test for coinbase connection to db (Gregory Sanders)
e532664 allow grabbing genesis transaction(s) when connected (Gregory Sanders)
c7e5549 [#9102] really don't validate genesis block (Gregory Sanders)
ccf40db connect genesis block transaction outputs to coin db (Gregory Sanders)

Pull request description:

  Tests should now be working.

Tree-SHA512: aa2af6637c534d7f9185e969118b52519fe0609ae79fa8f4d5213f939f9a5915f958cf93d02aa6f4a47795c87cc23c93daff3807347cb1b12a426326e6dea60e
@stevenroose
Copy link
Contributor

feature_block_subsidy.pyfeature_connect_coinbase.py | ✖ Failed | 1 s
I think the file got names wrong somehow somewhere...

@instagibbs
Copy link
Contributor Author

i pushed a fix, i missed a comma: d97920c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants