[0.17] Don't edit Chainparams after initialization #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtimon
changed the title
Contributor
|
Were you supposed to have the release notes commit there as well? |
Contributor
Author
|
I think there's no harm in having it but I got it from the bitcoin/0.17
branch without noticing. I can remove it if preferred.
…On Wed, 10 Oct 2018, 17:35 Steven Roose, ***@***.***> wrote:
Were you supposed to have the release notes commit there as well?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#427 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA9jSrmcE5lnDILQq4CzyxzXOFzOGOfUks5ujbFugaJpZM4XUfyL>
.
|
Contributor
|
tACK 36e1447 |
Contributor
|
the release notes change is noise, please remove |
Contributor
|
also it's building the apple image in travis? Didn't think we had that active. |
Contributor
|
oh of course this is 0.17. We should disable that build. |
instagibbs
changed the title
jtimon
force-pushed
the
e17-regtest-only-params
branch
from
36e1447 to
06f1b42
Compare
Contributor
Author
|
Removed release notes commit. |
2 tasks
jtimon
added a commit
that referenced
this pull request
Oct 13, 2018
06f1b42 Don't edit Chainparams after initialization (Jorge Timón) 875a47c MOVEONLY: Move versionbits info out of versionbits.o (Jorge Timón) Pull request description: This is a backport of bitcoin/bitcoin#13311 since it's already merged, merging this in elements-0.17 should at least make the next rebase slightly easier. And since we're heavily touching chainparams in elements, I think it's a good thing. Tree-SHA512: 177f6396a34ecf87b609b39a108cc2b1e5b49bd8d12b705a4ae0241c7a5007db754ff01d6d045ee1e6a219ec6c6767663cd98558752c83961c4aff3378aef5a2
instagibbs
added a commit
that referenced
this pull request
Oct 16, 2018
… tests a1e0c56 QA: Use resgtest2 chain instead of regtest for rpc tests (Jorge Timón) 4454c52 QA: Adapt BitcoinTestFramework for chains other than "regtest" (Jorge Timón) a06be15 Testchains: Introduce custom chain whose constructor... (Jorge Timón) 46749eb Testchains: Qt: Simplify network/chain styles and add a default purple (Jorge Timón) c0c1e38 Testchains: Generic selection with -chain=<str> in addition of -testnet and -regtest (Jorge Timón) 56515c3 9102: Really don't validate genesis block (Gregory Sanders) Pull request description: Backport of bitcoin/bitcoin#8994 The tests seem to pass with: ``` python3 ./test/functional/test_runner.py -j4 --extended ``` Let's please try to keep all general review things on bitcoin/bitcoin#8994 and elements-specific things here. Dependencies: - [x] [0.17] Don't edit Chainparams after initialization #427 - [x] [0.17] Test: Fix example_test.py #434 Tree-SHA512: e216587b6f9d3a462372915e01c8eb3c65a61e4ea29f398e65a7fc03a3ea5676c4711527b5cc2c115893591e7cd5b0ecd2f1fac4faf7ef747a022e2657bc99d4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of bitcoin/bitcoin#13311 since it's already merged, merging this in elements-0.17 should at least make the next rebase slightly easier. And since we're heavily touching chainparams in elements, I think it's a good thing.