HF: Move block.proof.challenge to Consensus::Params::signblockScript #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 22, 2017
jtimon
force-pushed
the
e14-blocksign-hf2
branch
from
63116fc to
0bb2f46
Compare
Contributor
Author
|
Rebased after #187 was merged for clarity. |
jtimon
force-pushed
the
e14-blocksign-hf2
branch
from
0bb2f46 to
ff4578f
Compare
Contributor
Author
|
Needed rebase. |
jtimon
commented
Aug 25, 2017
src/chainparams.cpp
Outdated
jtimon
force-pushed
the
e14-blocksign-hf2
branch
from
ff4578f to
77104e6
Compare
Contributor
Author
|
Fixed the auto-nit. https://travis-ci.org/ElementsProject/elements/jobs/268547573 was failing already. Yay travis! |
jtimon
force-pushed
the
e14-blocksign-hf2
branch
from
77104e6 to
b16fae1
Compare
jtimon
force-pushed
the
e14-blocksign-hf2
branch
from
b16fae1 to
c4eb0e0
Compare
Contributor
Author
|
Needed rebase |
jtimon
force-pushed
the
e14-blocksign-hf2
branch
2 times, most recently
from
5dbf35b to
3a7bc38
Compare
Contributor
|
concept ACK |
Contributor
|
concept ACK as well. I think it might be a good time to work on merging this. |
Contributor
Author
|
Some tests are failing. I will look it up (but if anyone else helps fixing them, that would be great). |
jtimon
force-pushed
the
e14-blocksign-hf2
branch
from
3a7bc38 to
2dfccc9
Compare
Contributor
Author
|
Rebased |
jtimon
force-pushed
the
e14-blocksign-hf2
branch
2 times, most recently
from
c8585d9 to
668b943
Compare
jtimon
force-pushed
the
e14-blocksign-hf2
branch
from
668b943 to
1bcf883
Compare
jtimon
force-pushed
the
e14-blocksign-hf2
branch
from
1bcf883 to
3bc1286
Compare
Since the scriptPubKey for signing blocks never changes, there's no point in repeating it with every block header.
jtimon
force-pushed
the
e14-blocksign-hf2
branch
from
3bc1286 to
2f40be5
Compare
Contributor
Author
|
Rebased |
Contributor
|
bunch of tests failing, haven't looked into it |
Contributor
Author
|
it seems sync_all is timing out for those tests, looks like a bug. |
2 tasks
Contributor
Author
|
Closed by accident, reopened as #313 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #114 but rebased to 0.14.
Dependencies: