more functional testing of pak mempool logic

Author: instagibbs

test/functional/feature_pak.py

@@ -262,6 +262,8 @@ def compare(actual, expected):
         # pak1 will now create a pegout.
         pak1_pegout_txid = self.nodes[i_pak1].sendtomainchain("", 1)["txid"]
         assert_equal(self.nodes[i_pak1].getwalletpakinfo()["bip32_counter"], "1")
+        # Also spend the change to make chained payment that will be rejected as well
+        pak1_child_txid = self.nodes[i_pak1].sendtoaddress(self.nodes[i_pak1].getnewaddress(), self.nodes[i_pak1].getbalance(), "", "", True)
 
 
         # Wait for two nodes to get transaction in mempool only
@@ -285,9 +287,20 @@ def compare(actual, expected):
 
         assert_equal(pak1_pegout_txid in self.nodes[i_novalidate].getrawmempool(), False)
         assert_equal(pak1_pegout_txid in self.nodes[i_undefined].getrawmempool(), False)
+        assert_equal(pak1_pegout_txid in self.nodes[i_pak1].getrawmempool(), True)
         assert_equal(pak1_pegout_txid in self.nodes[i_pak2].getrawmempool(), False)
         assert_equal(pak1_pegout_txid in self.nodes[i_reject].getrawmempool(), False)
 
+        assert_equal(self.nodes[i_pak1].gettransaction(pak1_pegout_txid)["confirmations"], 0)
+
+        # Make sure child payment also bumped from mempool
+        assert_equal(pak1_child_txid in self.nodes[i_novalidate].getrawmempool(), False)
+        assert_equal(pak1_child_txid in self.nodes[i_undefined].getrawmempool(), False)
+        assert_equal(pak1_child_txid in self.nodes[i_pak1].getrawmempool(), True)
+        assert_equal(pak1_child_txid in self.nodes[i_pak2].getrawmempool(), False)
+        assert_equal(pak1_child_txid in self.nodes[i_reject].getrawmempool(), False)
+
+        assert_equal(self.nodes[i_pak1].gettransaction(pak1_child_txid)["confirmations"], 0)
         # Fail to peg-out too-small value
         assert_raises_rpc_error(-8, "Invalid amount for send, must send more than 0.0001 BTC", self.nodes[i_undefined].sendtomainchain, "", Decimal('0.0009'))