fix nullable stream when getting dimensions of video

ElegantEngineeringTech · Jan 26, 2024 · 5cc8cfb · 5cc8cfb
1 parent b5f3d2a
commit 5cc8cfb
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/src/Helpers/HasDimension.php b/src/Helpers/HasDimension.php
@@ -7,7 +7,7 @@
 
 interface HasDimension
 {
-    public static function dimension(string $path): Dimension;
+    public static function dimension(string $path): ?Dimension;
 
-    public static function ratio(string $path, bool $forceStandards = true): AspectRatio;
+    public static function ratio(string $path, bool $forceStandards = true): ?AspectRatio;
 }
diff --git a/src/Helpers/Video.php b/src/Helpers/Video.php
@@ -9,7 +9,7 @@
 
 class Video implements HasDimension
 {
-    public static function dimension(string $path): Dimension
+    public static function dimension(string $path): ?Dimension
     {
         $file = FFProbe::create([
             'ffmpeg.binaries' => config('laravel-ffmpeg.ffmpeg.binaries'),
@@ -21,6 +21,10 @@ public static function dimension(string $path): Dimension
             ->videos()
             ->first();
 
+        if (! $stream) {
+            return null;
+        }
+
         $dimension = $stream->getDimensions();
 
         /** @var int */
@@ -33,9 +37,9 @@ public static function dimension(string $path): Dimension
         return $dimension;
     }
 
-    public static function ratio(string $path, bool $forceStandards = true): AspectRatio
+    public static function ratio(string $path, bool $forceStandards = true): ?AspectRatio
     {
-        return static::dimension($path)->getRatio($forceStandards);
+        return static::dimension($path)?->getRatio($forceStandards);
     }
 
     public static function duration(string $path): float