Reusable configuration keys

Artur Gafarov · Artur Gafarov · commit 71bbafa87bcf · 2021-04-20T00:46:40.000+03:00
diff --git a/src/ElasticEmailClient/ApiConfiguration.php b/src/ElasticEmailClient/ApiConfiguration.php
@@ -4,6 +4,8 @@
     class ApiConfiguration
     {
         const AVAILABLE_REQUEST_METHODS = ['GET', 'POST'];
+        const API_KEY = 'apiKey';
+        const API_URL = 'apiUrl';
 
         /**
          * @var string
@@ -31,8 +33,8 @@ class ApiConfiguration
          */
         public function __construct(array $params)
         {
-            $this->setApiKey($params['apiKey']);
-            $this->setApiUrl($params['apiUrl']);
+            $this->setApiKey($params[self::API_KEY]);
+            $this->setApiUrl($params[self::API_URL]);
         }
 
         /**

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,8 @@`
`4`	`4`	`class ApiConfiguration`
`5`	`5`	`{`
`6`	`6`	`const AVAILABLE_REQUEST_METHODS = ['GET', 'POST'];`
	`7`	`+ const API_KEY = 'apiKey';`
	`8`	`+ const API_URL = 'apiUrl';`
`7`	`9`
`8`	`10`	`/**`
`9`	`11`	`* @var string`
`@@ -31,8 +33,8 @@ class ApiConfiguration`
`31`	`33`	`*/`
`32`	`34`	`public function __construct(array $params)`
`33`	`35`	`{`
`34`		`- $this->setApiKey($params['apiKey']);`
`35`		`- $this->setApiUrl($params['apiUrl']);`
	`36`	`+ $this->setApiKey($params[self::API_KEY]);`
	`37`	`+ $this->setApiUrl($params[self::API_URL]);`
`36`	`38`	`}`
`37`	`39`
`38`	`40`	`/**`