Skip to content

Commit

Permalink
Jekyll: exclude "tests" directory
Browse files Browse the repository at this point in the history
Netlify reported "mixed content" warnings (which means that the
website contained links to both HTTPS and HTTP URLs.

Those reports were based on some test-files in the "tests" directory;

```
10:08:07 PM: Finished processing build request in 6m14.58941986s
10:09:14 PM: Mixed content detected in: /tests/src/golang.org/x/net/html/charset/testdata/utf-8-bom-vs-meta-content.html
10:09:15 PM: --> insecure link urls:
10:09:15 PM:   - http://www.w3.org/TR/html5/syntax.html#the-input-byte-stream
10:09:15 PM: --> insecure script urls:
10:09:15 PM:   - http://w3c-test.org/resources/testharness.js
10:09:15 PM:   - http://w3c-test.org/resources/testharnessreport.js
10:09:15 PM: Mixed content detected in: /tests/src/golang.org/x/net/html/charset/testdata/utf-8-bom-vs-meta-charset.html
10:09:15 PM: --> insecure link urls:
10:09:15 PM:   - http://www.w3.org/TR/html5/syntax.html#the-input-byte-stream
10:09:15 PM: --> insecure script urls:
10:09:15 PM:   - http://w3c-test.org/resources/testharness.js
10:09:15 PM:   - http://w3c-test.org/resources/testharnessreport.js
```

We already look to be excluding that directory from our Dockerfile, but
possibly Netlify uses the source itself for this detection, so adding
`tests` to the `exclude` list in the Jenkyll configuration.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
  • Loading branch information
thaJeztah committed May 11, 2020
1 parent 53569a8 commit c868bbc
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion _config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ safe: false
lsi: false
# This needs to have all the directories you expect to be in the archives (delivered by docs-base in the Dockerfile)
keep_files: ["v17.06", "v18.03", "v18.09"]
exclude: ["_scripts", "apidocs/layouts", "Gemfile", "hooks", "index.html", "404.html"]
exclude: ["_scripts", "tests", "apidocs/layouts", "Gemfile", "hooks", "index.html", "404.html"]

# Component versions -- address like site.docker_ce_version
# You can't have - characters in these for non-YAML reasons
Expand Down
2 changes: 1 addition & 1 deletion _config_authoring.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ safe: false
lsi: false
# This needs to have all the directories you expect to be in the archives (delivered by docs-base in the Dockerfile)
keep_files: ["v17.06", "v18.03", "v18.09"]
exclude: ["_scripts", "apidocs/layouts", "Gemfile", "hooks", "index.html", "404.html"]
exclude: ["_scripts", "tests", "apidocs/layouts", "Gemfile", "hooks", "index.html", "404.html"]

# Component versions -- address like site.docker_ce_version
# You can't have - characters in these for non-YAML reasons
Expand Down

0 comments on commit c868bbc

Please sign in to comment.