🐛 #186: update timeouts per example in time package

[mkrueger12]

• changed defaultTimeout, readTimeout, writeTimeout, and idleTimeout to remove multiplication bug

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.58%. Comparing base (369ddea) to head (05a4964).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop     #187   +/-   ##
========================================
  Coverage    66.58%   66.58%           
========================================
  Files           73       73           
  Lines         3163     3163           
========================================
  Hits          2106     2106           
  Misses         948      948           
  Partials       109      109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[roma-glushko]

This is interesting 👀

10 * time.Second, let's say, should be a valid Golang way to define 10 sec interval. I'm wondering what sort of problem that has caused 🤔

[mkrueger12]

@roma-glushko I noticed the timeouts we're 10,000,000,000 in the router config. Not sure if that was seconds or ms but the math still doesn't align to 10s

[roma-glushko]

@mkrueger12 My guess it's really 10s but it's just rendered somewhere in micro or nanoseconds which might be confusing. Can you make me a screenshot where you saw that?

[mkrueger12]

[roma-glushko]

Okay, I see. Yes, that's just a confusing way to output that value. The value itself should be fine.
Need to play with swaggertype/JSON to see if it helps to improve the format of Durations

Here is an example of what I was doing in other places to fix another problem:

glide/pkg/routers/retry/config.go

Line 8 in f76eb86

MinDelay time.Duration `yaml:"min_delay,omitempty" json:"min_delay" swaggertype:"primitive,integer"`

[roma-glushko]

Gonna close this PR in favour of #202. Thanks!