🔧 #161: Refined the chat stream req/responses#179
Merged
Conversation
… finish reason field & added metadata to stream chat response
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #179 +/- ##
===========================================
+ Coverage 66.61% 66.68% +0.07%
===========================================
Files 70 70
Lines 3082 3119 +37
===========================================
+ Hits 2053 2080 +27
- Misses 925 934 +9
- Partials 104 105 +1 ☔ View full report in Codecov by Sentry. |
mkrueger12
reviewed
Mar 18, 2024
| @@ -17,7 +17,7 @@ func NewChatFromStr(message string) *ChatRequest { | |||
| Message: ChatMessage{ | |||
| "human", | |||
Contributor
There was a problem hiding this comment.
I think this needs to be "user" instead of "human"
Contributor
There was a problem hiding this comment.
Since all providers take "user" as input in request schema
Member
Author
There was a problem hiding this comment.
I see yeah it makes sense to change that. However, it makes almost no effect as it's used in tests only to mock request schema. I will take care of this in a followup PR 👀
mkrueger12
approved these changes
Mar 18, 2024
| func NewChatStreamFromStr(message string) *ChatStreamRequest { | ||
| return &ChatStreamRequest{ | ||
| Message: ChatMessage{ | ||
| "human", |
Contributor
There was a problem hiding this comment.
Should be "user" instead of human"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes