Skip to content

Added complex manipulation ops and unit tests for added ops #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Nov 26, 2020
Merged

Added complex manipulation ops and unit tests for added ops #2

merged 20 commits into from
Nov 26, 2020

Conversation

zaccharieramzi
Copy link

This PR adds:

  • complex manipulation ops (going from and to complex-valued tensors)
  • tests for complex manipulation ops
  • tests for signal ops (fft3d and ifft3d)

The tests are passing in the current state, but I am going to suggest in a comment underneath some modifications to the current code.

@zaccharieramzi
Copy link
Author

My suggestions:

  • refactor the code for the fourier operators, with a base class sharing all the commonalities
  • clarify the shape transposing in the docs

Copy link
Owner

@EiffL EiffL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I've suggested a few modifications, let me know what you think and I can implement them if you agree :-)

@EiffL
Copy link
Owner

EiffL commented Nov 26, 2020

Ok I've made the executive decision of adding the code for the transpose inside the base class, the logic is this particular order of transpose is connected to the rest of the fft algorithm, so kind of awkward to have it alone in a different class

@EiffL EiffL self-requested a review November 26, 2020 19:33
Copy link
Owner

@EiffL EiffL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, for some reasons the tests are not running automatically on github, I'm gonna try to ru them on my machine and after that it's all good

@EiffL EiffL merged commit 3bcaef8 into EiffL:spectral Nov 26, 2020
@EiffL
Copy link
Owner

EiffL commented Nov 26, 2020

ok, all good. Thanks @zaccharieramzi !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants