Skip to content

Commit 3c72126

Browse files
committed
revert(83f5e53): rename to remove 'es' at end
Though it may make more sense to include 'es' at the end, (since it can contain many classes), it is more standard to exclude the 'es' chore(BImg): add some notes about TODOs chore(useBooleanish): add note about future Vue code possibilities fix(BTableContainer): rename prop responsiveClasses to responsiveClass fix(BDropdownGroup): rename headerClasses prop to headerClass chore(BAvatar): remove old note
1 parent 83f5e53 commit 3c72126

File tree

6 files changed

+16
-12
lines changed

6 files changed

+16
-12
lines changed

packages/bootstrap-vue-3/src/components/BAvatar/BAvatar.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ interface BAvatarProps {
5151
square?: Booleanish
5252
src?: string
5353
text?: string
54-
textVariant?: ColorVariant // not standard BootstrapVue props
54+
textVariant?: ColorVariant
5555
variant?: ColorVariant
5656
}
5757

packages/bootstrap-vue-3/src/components/BCard/BCard.vue

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@
44
<b-card-header
55
v-if="header || $slots.header || headerHtml"
66
v-bind="headerAttrs"
7-
:class="headerClasses"
7+
:class="headerClass"
88
>
99
<slot name="header">
1010
{{ header }}
1111
</slot>
1212
</b-card-header>
13-
<b-card-body v-if="!noBodyBoolean" v-bind="bodyAttrs" :class="bodyClasses">
13+
<b-card-body v-if="!noBodyBoolean" v-bind="bodyAttrs" :class="bodyClass">
1414
<slot>
1515
{{ bodyText }}
1616
</slot>
@@ -21,7 +21,7 @@
2121
<b-card-footer
2222
v-if="footer || $slots.footer || footerHtml"
2323
v-bind="footerAttrs"
24-
:class="footerClasses"
24+
:class="footerClass"
2525
>
2626
<slot name="footer">
2727
{{ footer }}
@@ -45,21 +45,21 @@ interface BCardProps {
4545
align?: Alignment
4646
bgVariant?: ColorVariant
4747
bodyBgVariant?: ColorVariant
48-
bodyClasses?: ClassValue
48+
bodyClass?: ClassValue
4949
bodyTag?: string
5050
bodyTextVariant?: TextColorVariant
5151
borderVariant?: ColorVariant
5252
footer?: string
5353
footerBgVariant?: ColorVariant
5454
footerBorderVariant?: ColorVariant
55-
footerClasses?: ClassValue
55+
footerClass?: ClassValue
5656
footerHtml?: string
5757
footerTag?: string
5858
footerTextVariant?: TextColorVariant
5959
header?: string
6060
headerBgVariant?: ColorVariant
6161
headerBorderVariant?: ColorVariant
62-
headerClasses?: ClassValue
62+
headerClass?: ClassValue
6363
headerHtml?: string
6464
headerTag?: string
6565
headerTextVariant?: TextColorVariant

packages/bootstrap-vue-3/src/components/BDropdown/BDropdownGroup.vue

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
:is="headerTag"
55
:id="headerId"
66
class="dropdown-header"
7-
:class="[classes, headerClasses]"
7+
:class="[classes, headerClass]"
88
:role="headerRole"
99
>
1010
<slot name="header">
@@ -32,14 +32,14 @@ interface BDropdownGroupProps {
3232
id?: string
3333
ariaDescribedby?: string
3434
header?: string
35-
headerClasses?: ClassValue
35+
headerClass?: ClassValue
3636
headerTag?: string
3737
headerVariant?: ColorVariant
3838
}
3939
4040
const props = withDefaults(defineProps<BDropdownGroupProps>(), {
4141
headerTag: 'header',
42-
headerClasses: undefined,
42+
headerClass: undefined,
4343
})
4444
4545
const headerId = computed<string | undefined>(() =>

packages/bootstrap-vue-3/src/components/BImg.vue

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ const makeBlankImgSrc = (width: any, height: any, color: string): string => {
7474
}
7575
7676
const attrs = computed(() => {
77+
// TODO decompose this and make business logic into separate computed functions
7778
let {src} = props
7879
let width =
7980
(typeof props.width === 'number' ? props.width : parseInt(props.width as string, 10)) ||
@@ -109,6 +110,7 @@ const attrs = computed(() => {
109110
height = 1
110111
}
111112
// Make a blank SVG image
113+
// TODO unexpected mutation of props
112114
src = makeBlankImgSrc(width, height, props.blankColor || 'transparent')
113115
// Disable srcset and sizes
114116
srcset = ''

packages/bootstrap-vue-3/src/components/BTable/BTableContainer.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<template>
2-
<div v-if="responsive" :class="responsiveClasses">
2+
<div v-if="responsive" :class="responsiveClass">
33
<slot />
44
</div>
55
<template v-else>
@@ -12,7 +12,7 @@ import type {ClassValue} from '../../types'
1212
1313
interface BTableContainerProps {
1414
responsive?: boolean | 'sm' | 'md' | 'lg' | 'xl' | 'xxl'
15-
responsiveClasses?: ClassValue
15+
responsiveClass?: ClassValue
1616
}
1717
1818
withDefaults(defineProps<BTableContainerProps>(), {

packages/bootstrap-vue-3/src/composables/useBooleanish.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@ import type {Booleanish} from '../types'
22
import {computed, ComputedRef, Ref} from 'vue'
33
import {resolveBooleanish} from '../utils'
44

5+
// function useBooleanish<T>(el: Ref<Booleanish | T>): ComputedRef<boolean | T>
6+
// This may possibily be used in Vue 3.3 to include Booleanish and complex types ie Booleanish | string
57
function useBooleanish(el: Ref<Booleanish>): ComputedRef<boolean>
68
function useBooleanish(el: Ref<Booleanish | undefined>): ComputedRef<boolean | undefined>
79
function useBooleanish(

0 commit comments

Comments
 (0)