Skip to content

Conversation

@vinassefranche
Copy link
Contributor

@vinassefranche vinassefranche commented Jan 21, 2025

Type

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

This adds HashMap.toValues() that returns the values of a HashMap as an array instead of as an iterator like is the case for HashMap.values(). Also add HashSet.toValues().

I took inspiration from entries vs toEntries for the naming. I don't know if there's another convention for this.

Related

  • Related Issue #
  • Closes #

@changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2025

🦋 Changeset detected

Latest commit: 2415c58

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
effect Minor
@effect/cli Major
@effect/cluster-browser Major
@effect/cluster-node Major
@effect/cluster-workflow Major
@effect/cluster Major
@effect/experimental Major
@effect/opentelemetry Major
@effect/platform-browser Major
@effect/platform-bun Major
@effect/platform-node-shared Major
@effect/platform-node Major
@effect/platform Major
@effect/printer-ansi Major
@effect/printer Major
@effect/rpc-http Major
@effect/rpc Major
@effect/sql-clickhouse Major
@effect/sql-d1 Major
@effect/sql-drizzle Major
@effect/sql-kysely Major
@effect/sql-libsql Major
@effect/sql-mssql Major
@effect/sql-mysql2 Major
@effect/sql-pg Major
@effect/sql-sqlite-bun Major
@effect/sql-sqlite-do Major
@effect/sql-sqlite-node Major
@effect/sql-sqlite-react-native Major
@effect/sql-sqlite-wasm Major
@effect/sql Major
@effect/typeclass Major
@effect/vitest Major
@effect/ai Major
@effect/ai-openai Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@effect-bot effect-bot changed the base branch from next-minor to next-major January 21, 2025 17:06
@effect-bot effect-bot changed the base branch from next-major to next-minor January 21, 2025 17:07
@effect-bot effect-bot force-pushed the next-minor branch 11 times, most recently from f8ef188 to 58d0262 Compare January 22, 2025 14:57
@effect-bot effect-bot force-pushed the next-minor branch 4 times, most recently from 2cb96fe to 6bf15ff Compare January 23, 2025 11:45
@effect-bot effect-bot force-pushed the next-minor branch 14 times, most recently from 3af36c8 to b2b17d6 Compare February 11, 2025 10:10
@thewilkybarkid
Copy link
Contributor

This would be useful for HashSet too.

@effect-bot effect-bot force-pushed the next-minor branch 3 times, most recently from b878f64 to 46ed7b6 Compare February 11, 2025 18:40
@vinassefranche vinassefranche changed the title Add HashMap.tovalues Add HashMap.toValues and HashSet.toValues Feb 11, 2025
@vinassefranche
Copy link
Contributor Author

This would be useful for HashSet too.

indeed. I added it to the P.R.

@effect-bot effect-bot force-pushed the next-minor branch 3 times, most recently from 757f32f to fdc729c Compare February 13, 2025 07:58
@tim-smart tim-smart merged commit 0e4ac5d into Effect-TS:next-minor Feb 14, 2025
12 checks passed
@effect-bot effect-bot mentioned this pull request Feb 14, 2025
@vinassefranche vinassefranche deleted the add-hashmap-tovalues branch February 14, 2025 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants