-
-
Notifications
You must be signed in to change notification settings - Fork 447
Add HashMap.toValues and HashSet.toValues #4317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tim-smart
merged 4 commits into
Effect-TS:next-minor
from
vinassefranche:add-hashmap-tovalues
Feb 14, 2025
Merged
Add HashMap.toValues and HashSet.toValues #4317
tim-smart
merged 4 commits into
Effect-TS:next-minor
from
vinassefranche:add-hashmap-tovalues
Feb 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2415c58 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
d944d54 to
16d6bc9
Compare
f8ef188 to
58d0262
Compare
2cb96fe to
6bf15ff
Compare
3af36c8 to
b2b17d6
Compare
Contributor
|
This would be useful for |
b878f64 to
46ed7b6
Compare
Contributor
Author
indeed. I added it to the P.R. |
757f32f to
fdc729c
Compare
tim-smart
approved these changes
Feb 13, 2025
Merged
tim-smart
pushed a commit
that referenced
this pull request
Feb 14, 2025
tim-smart
pushed a commit
that referenced
this pull request
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description
This adds
HashMap.toValues()that returns the values of aHashMapas an array instead of as an iterator like is the case forHashMap.values(). Also addHashSet.toValues().I took inspiration from
entriesvstoEntriesfor the naming. I don't know if there's another convention for this.Related