Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add token decoding functionality to login/registration views #153" and refactor into a better method #155

Open
ghost opened this issue Mar 3, 2020 · 0 comments
Assignees

Comments

@ghost
Copy link

ghost commented Mar 3, 2020

Before the Hawthorn release we did the following PR:

I had a couple of notes that I want us to address:

  • This PR has a couple of inline changes that would make it difficult to manage in future releases.
  • Adding tests would make future merges easier to verify. This is a good mitigation even if it doesn't make them go away.
  • I still need more background about the nature of the issue we're solving, but my initial though is that we could use "encoding" like Base64 instead of a shared-key "encryption".
@ghost ghost assigned shadinaif Mar 3, 2020
@ghost ghost changed the title Revert "" and refactor into a better method Revert "Add token decoding functionality to login/registration views #153" and refactor into a better method Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant