fix: add ability to make dialogs active/inactive

patrickocoffeyo · patrickocoffeyo · commit 8b1dd59e38bb · 2018-08-03T11:47:25.000-05:00
diff --git a/README.md b/README.md
@@ -16,11 +16,12 @@ For [A-Frame](https://aframe.io).
 | titleColor             | Text color of title.        | black                         |
 | titleFont              | Title font.                 | mozillavr                     |
 | titleWrapCount         | Title entity wrap count.    | 24                            |
-| body                   | String containing body .    | This dialog has no body yet.  |
+| body                   | String containing body.     | This dialog has no body yet.  |
 | bodyColor              | Text color of body.         | black                         |
 | bodyFont               | Body  font.                 | mozillavr                     |
 | bodyWrapCount          | Body entity wrap count.     | 30                            |
 | openOn                 | Open/Close event.           | click                         |
+| active                 | Turn dialog on/off.         | true                          |
 | openIconImage          | Icon image for open button. | None                          |
 | openIconRadius         | Radius for open icon.       | 0.3                           |
 | openIconColor          | Color for open icon.        | white                         |
@@ -45,7 +46,7 @@ Install and use by directly including the [browser files](dist):
 <head>
   <title>My A-Frame Scene</title>
   <script src="https://aframe.io/releases/0.8.2/aframe.min.js"></script>
-  <script src="https://unpkg.com/@editvr/aframe-dialog-popup-component@1.4.0/dist/aframe-dialog-popup-component.min.js"></script>
+  <script src="https://unpkg.com/@editvr/aframe-dialog-popup-component@1.7.2/dist/aframe-dialog-popup-component.min.js"></script>
 </head>
 
 <body>
diff --git a/dist/aframe-dialog-popup-component.js b/dist/aframe-dialog-popup-component.js
@@ -125,6 +125,10 @@ AFRAME.registerComponent('dialog-popup', {
       type: 'string',
       default: 'click'
     },
+    active: {
+      type: 'boolean',
+      default: true
+    },
     openIconImage: {
       type: 'asset',
       default: ''
@@ -230,7 +234,7 @@ AFRAME.registerComponent('dialog-popup', {
   toggleDialogOpen: function toggleDialogOpen() {
     this.isOpen = !this.isOpen;
 
-    if (this.dialogPlaneEl) {
+    if (this.data.active && this.dialogPlaneEl) {
       this.positionDialogPlane();
       this.dialogPlaneEl.setAttribute('visible', this.isOpen);
       this.openIconEl.setAttribute('visible', !this.isOpen);
diff --git a/dist/aframe-dialog-popup-component.min.js b/dist/aframe-dialog-popup-component.min.js
diff --git a/index.js b/index.js
@@ -52,6 +52,10 @@ AFRAME.registerComponent('dialog-popup', {
       type: 'string',
       default: 'click'
     },
+    active: {
+      type: 'boolean',
+      default: true,
+    },
     openIconImage: {
       type: 'asset',
       default: ''
@@ -157,7 +161,7 @@ AFRAME.registerComponent('dialog-popup', {
    */
   toggleDialogOpen() {
     this.isOpen = !this.isOpen;
-    if (this.dialogPlaneEl) {
+    if (this.data.active && this.dialogPlaneEl) {
       this.positionDialogPlane();
       this.dialogPlaneEl.setAttribute('visible', this.isOpen);
       this.openIconEl.setAttribute('visible', !this.isOpen);
