Skip to content

Commit 948608d

Browse files
sebmarkbageAndyPengc12
authored andcommitted
Emit Server Error Prefix in the .stack Property Too (facebook#28738)
Follow up to facebook#28684. V8 includes the message in the stack and printed errors include just the stack property which is assumed to contain the message. Without this, the prefix doesn't get printed in the console. <img width="578" alt="Screenshot 2024-04-03 at 6 32 04 PM" src="https://github.com/facebook/react/assets/63648/d98a2db4-6ebc-4805-b669-59f449dfd21f"> A possible alternative would be to use a nested error with a `cause` like facebook#28736 but that would need some more involved serializing since this prefix is coming from the server. Perhaps as a separate attribute.
1 parent d253d71 commit 948608d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

packages/react-server/src/ReactFizzServer.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -842,7 +842,7 @@ function encodeErrorForBoundary(
842842
? 'Switched to client rendering because the server rendering aborted due to:\n\n'
843843
: 'Switched to client rendering because the server rendering errored:\n\n';
844844
boundary.errorMessage = prefix + message;
845-
boundary.errorStack = stack;
845+
boundary.errorStack = stack !== null ? prefix + stack : null;
846846
boundary.errorComponentStack = thrownInfo.componentStack;
847847
}
848848
}

0 commit comments

Comments
 (0)