Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: EdgeApp/edge-react-gui
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: develop
Choose a base ref
...
head repository: EdgeApp/edge-react-gui
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: test-gouda
Choose a head ref
  • 3 commits
  • 7 files changed
  • 1 contributor

Commits on Jul 29, 2025

  1. Configuration menu
    Copy the full SHA
    2f89e81 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2025

  1. Fix styled HOC circular dependency issue

    Add optional chaining to handle cases where Component is undefined
    during module loading due to circular dependencies.
    
    Problem: When styled components are created at module load time,
    circular dependencies can cause the Component parameter to be undefined
    (e.g., AlertDropdown -> EdgeTouchableOpacity -> AirshipInstance -> AlertDropdown).
    This resulted in 'Cannot read properties of undefined (reading displayName)' errors.
    
    Solution: Use optional chaining (Component?.displayName) to safely
    access displayName property, preventing TypeError during circular
    dependency resolution.
    samholmes committed Jul 30, 2025
    Configuration menu
    Copy the full SHA
    26104fc View commit details
    Browse the repository at this point in the history
  2. Implement user action error reporting button

    Add error reporting functionality to AlertDropdown component:
    
    - When error prop is provided, dropdown becomes persistent and shows
      Report Error button at bottom
    - Report Error button tracks error to Sentry with userReportedError metadata
    - After reporting, shows success state with checkmark and 'Report sent' message
    - Auto-dismisses after 3 seconds to allow user to read confirmation
    - Uses localized strings for button text and success message
    - Disables dropdown onPress to prevent accidental dismissal during error state
    
    The implementation uses styled components for the error UI elements,
    which now work correctly thanks to the circular dependency fix in the
    styled HOC.
    samholmes committed Jul 30, 2025
    Configuration menu
    Copy the full SHA
    c7d8b8e View commit details
    Browse the repository at this point in the history
Loading