Enable no-deprecated #10723

Author: PowerKiKi

eslint.config.mjs

@@ -77,7 +77,6 @@ function tsFiles(files, extraRules = {}) {
             '@typescript-eslint/no-unsafe-return': 'off',
             '@typescript-eslint/prefer-nullish-coalescing': 'off', // Usually a good idea, but sometimes dangerous false-positive
             '@typescript-eslint/unbound-method': 'off',
-            '@typescript-eslint/no-deprecated': 'off', // TODO Angular 19: enable and solves them
             '@typescript-eslint/no-unnecessary-type-parameters': 'off', // The doc is scary, let's revisit this when we have time
             '@angular-eslint/prefer-signals': [
                 'error',

projects/natural-editor/src/lib/editor/editor.component.ts

@@ -175,6 +175,7 @@ export class NaturalEditorComponent implements OnInit, OnDestroy, ControlValueAc
     }
 
     private createPlugins(): Plugin[] {
+        // eslint-disable-next-line @typescript-eslint/no-deprecated
         const isMac = !!this.document.defaultView?.navigator.platform.match(/Mac/);
 
         const plugins = [

projects/natural/src/lib/classes/utility.ts

@@ -206,6 +206,7 @@ export function copyToClipboard(document: Document, text: string): void {
     document.body.append(input);
     input.value = text;
     input.select();
+    // eslint-disable-next-line @typescript-eslint/no-deprecated
     document.execCommand('copy');
     document.body.removeChild(input);
 }

projects/natural/src/lib/modules/common/pipes/ellipsis.pipe.ts

@@ -6,6 +6,6 @@ import {Pipe, PipeTransform} from '@angular/core';
 })
 export class NaturalEllipsisPipe implements PipeTransform {
     public transform(value: string, limit: number): string {
-        return value.substr(0, limit - 1) + (value.length > limit ? '…' : '');
+        return value.substring(0, limit - 1) + (value.length > limit ? '…' : '');
     }
 }

projects/natural/src/lib/modules/file/component/file.component.ts

@@ -174,6 +174,7 @@ export class NaturalFileComponent implements OnInit, OnChanges {
             subject.next(btoa(ev.target.result));
             subject.complete();
         });
+        // eslint-disable-next-line @typescript-eslint/no-deprecated
         reader.readAsBinaryString(file);
 
         return subject.asObservable();

projects/natural/src/lib/modules/hierarchic-selector/hierarchic-selector/hierarchic-selector.component.ts

@@ -108,8 +108,11 @@ export class NaturalHierarchicSelectorComponent implements OnInit, OnChanges {
      */
     public flatNodesSelection!: SelectionModel<HierarchicFlatNode>;
 
+    // eslint-disable-next-line @typescript-eslint/no-deprecated
     public treeControl!: FlatTreeControl<HierarchicFlatNode>;
+    // eslint-disable-next-line @typescript-eslint/no-deprecated
     public treeFlattener!: MatTreeFlattener<HierarchicModelNode, HierarchicFlatNode>;
+    // eslint-disable-next-line @typescript-eslint/no-deprecated
     public dataSource!: MatTreeFlatDataSource<HierarchicModelNode, HierarchicFlatNode>;
 
     public loading = false;
@@ -140,16 +143,19 @@ export class NaturalHierarchicSelectorComponent implements OnInit, OnChanges {
         this.flatNodesSelection = new SelectionModel<any>(this.multiple);
 
         // Tree controllers and manipulators
+        // eslint-disable-next-line @typescript-eslint/no-deprecated
         this.treeFlattener = new MatTreeFlattener(
             this.transformer(),
             this.getLevel(),
             this.isExpandable(),
             this.getChildren(),
         );
+        // eslint-disable-next-line @typescript-eslint/no-deprecated
         this.treeControl = new FlatTreeControl<HierarchicFlatNode>(this.getLevel(), this.isExpandable());
 
         // The dataSource contains a nested ModelNodes list. Each ModelNode has a child attribute that returns an observable.
         // The dataSource contains a flat representation of the nested ModelNodes that is generated by the treeFlattener related functions
+        // eslint-disable-next-line @typescript-eslint/no-deprecated
         this.dataSource = new MatTreeFlatDataSource(this.treeControl, this.treeFlattener);
 
         // Update dataSource when receiving new list -> we assign the whole tree