Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing broken ui in case of "|" #10880

Merged
merged 4 commits into from
Nov 22, 2023
Merged

Conversation

lakshmi930
Copy link
Contributor

@lakshmi930 lakshmi930 commented Oct 29, 2023

What does this PR do?

Improve repo

Fixes:
image

Checklist:

  • Read our contributing guidelines.
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction).
  • Used an informative name for this pull request.

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@lakshmi930
Copy link
Contributor Author

@eshellman noticed this issue when navigated to one of the language documents. Fixed the issue for other pages as well.

@eshellman
Copy link
Collaborator

thanks for this. We won't merge it until the hacktoberfest PRs are cleared out because of the potential to create conflict

@eshellman eshellman added the keep Requests exempt from being punctually stale label Oct 29, 2023
@github-actions github-actions bot added the conflicts Conflict(s) need to be resolved label Oct 31, 2023
@github-actions
Copy link

Oh no 😟! Conflicts have been found.

Please 🙏, take a moment and address the merge conflicts of your pull request before we can evaluate it again.

Thanks in advance for your effort and patience ❤️!

@github-actions github-actions bot added conflicts Conflict(s) need to be resolved and removed conflicts Conflict(s) need to be resolved labels Oct 31, 2023
Copy link

github-actions bot commented Nov 1, 2023

Oh no 😟! Conflicts have been found.

Please 🙏, take a moment and address the merge conflicts of your pull request before we can evaluate it again.

Thanks in advance for your effort and patience ❤️!

@github-actions github-actions bot removed the conflicts Conflict(s) need to be resolved label Nov 1, 2023
Copy link

github-actions bot commented Nov 1, 2023

Linter failed, fix the error(s):

free-programming-books/courses/free-courses-hi.md
159:1-164:129  warning  Alphabetical ordering: swap l.164 and l.163  alphabetize-lists  remark-lint

@github-actions github-actions bot added the linter error Please, correct build errors found by linter! label Nov 1, 2023
@github-actions github-actions bot removed the linter error Please, correct build errors found by linter! label Nov 1, 2023
@lakshmi930
Copy link
Contributor Author

Hello @eshellman, thanks for your reply. Is this PR going to be merged as Hacktoberfest is now over?

@eshellman
Copy link
Collaborator

We've cleared about half of the backlog from Hacktoberfest - you can see how many of those are waiting for conflicts to be fixed!

@eshellman eshellman merged commit ea1b270 into EbookFoundation:main Nov 22, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep Requests exempt from being punctually stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants