Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Format files using Prettier code formatter #737

Merged
merged 4 commits into from
Nov 10, 2020
Merged

Feature: Format files using Prettier code formatter #737

merged 4 commits into from
Nov 10, 2020

Conversation

marcobiedermann
Copy link
Contributor

Add Prettier code formatter as devDependency in order to format files.
I've also added some instructions on how to run it in the README.
In addition, to apply this to all new changes, I've added a pre-commit hook using husky to run Prettier on all staged files.

Preview: https://github.com/marcobiedermann/in-quiz-questions/tree/feature/prettier

Add Prettier to format files
Format staged files using pre-commit hook
Format files using Prettier code formatter
@marcobiedermann
Copy link
Contributor Author

@Ebazhanov

Note: Resolved conflicts and rebased to latest master.

Sorry to be a bit pushy here but in case you would agree with those changes, could we get this is as soon as possible because everything will built upon it.
Otherwise, I would have to rebase every time, there are new changes to the repo.

Copy link
Owner

@Ebazhanov Ebazhanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcobiedermann thank you 🔥! I really love this ❤️, now I am feeling that we made a great improvement with your contribution! 💪

@Ebazhanov Ebazhanov merged commit 8f797e2 into Ebazhanov:master Nov 10, 2020
@Ebazhanov
Copy link
Owner

@all-contributors please add @marcobiedermann for business, ideas

@allcontributors
Copy link
Contributor

@Ebazhanov

I've put up a pull request to add @marcobiedermann! 🎉

@marcobiedermann marcobiedermann deleted the feature/prettier branch November 10, 2020 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants