Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

single eps: should we use euclidean distance as default? #15

Closed
scheidan opened this issue Aug 16, 2024 · 3 comments
Closed

single eps: should we use euclidean distance as default? #15

scheidan opened this issue Aug 16, 2024 · 3 comments

Comments

@scheidan
Copy link
Collaborator

If a user provides multiple stats and uses type = :single, should we

  1. throw an error, or
  2. compute the (unweighted) euclidean distance of all stats?

Currently we do (2) but I think I'd prefer (1). There is not reason why we can assume that an unweighted distance is meaningful in general.

@scheidan
Copy link
Collaborator Author

I went for option 2.
Still need to be documented

@scheidan
Copy link
Collaborator Author

  • no automatic distance computations
  • find a way how to log individual components in the user code -> make example
  • type = :single becomes a special case of type :multi, remove options. New default :hybrid

@scheidan
Copy link
Collaborator Author

done with 8ac7bf4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant