Add support for MEDIUMBLOB and CHAR #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yonran
commented
Mar 18, 2020
yonran
force-pushed
the
mediumblob-and-char
branch
from
54bce8a
to
4be5e79
Compare
|
This looks reasonable; can you rebase on master (sorry for all the conflicts)? |
OscarTHZhang
approved these changes
May 30, 2021
|
@yonran are you able to rebase against master? |
yonran
force-pushed
the
mediumblob-and-char
branch
from
4be5e79
to
b687d42
Compare
|
@Justintime50 sure I just rebased it |
Add support for parsing CHAR(n) columns BINARY(n) columns no longer cause a panic, but the value is not usable (since it is converted to utf-8). SET and ENUM columns no longer panic in read_metadata, but they still panic in read_value
Roguelazer
force-pushed
the
mediumblob-and-char
branch
from
b687d42
to
ce4f2b4
Compare
Roguelazer
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MEDIUMBLOBcolumns (previously panicked)VecinBlob(Vec<u8>)public so that you can read theBLOBorTEXTdataCHAR(n)columns (previously panicked) by parsing theMYSQL_TYPE_STRINGlength according tolog_event_print_valuein log_event.cc (which is the reference according to MySQL Internals Manual -> The Binary Log -> Event Data for Specific Event Types)BINARY(n)column (previously panicked), although the byte data is currently lostColumnType::SetandColumnType::TinyBlobinColumnType::from_byteto match mysql-server’s field_types.cc