feat: adds new recommend_ship_date and estimate_delivery_date functions #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchen293
previously approved these changes
Jul 10, 2024
nwithan8
suggested changes
Jul 10, 2024
nwithan8
previously approved these changes
Jul 10, 2024
nwithan8
approved these changes
Jul 10, 2024
jchen293
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
shipment.recommend_ship_date,smartrate.recommend_ship_date, andsmartrate.estimate_delivery_datefunctionsTesting
Adds new tests that work similarly to how previous smartrate tests work
Pull Request Type
Please select the option(s) that are relevant to this PR.