Exception overhaul #241
Merged
Exception overhaul #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix:ecode to code chore: first batch of errors migrated fix: exception inheritence and locations feat: import all exceptions feat: convert remainder of errors fix: tests relating to errors fix: lint feat: use remaining error types depending on status code fix: throws docblock comments fix: last minute things
Justintime50
force-pushed
the
exception_overhaul
branch
from
fa8fb8e to
54096cb
Compare
jchen293
reviewed
Dec 13, 2022
nwithan8
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Overhauls Exceptions by adding ~2 dozen new exception types. Exceptions from our API will extend
ApiException(previously EasyPostException) and errors originating directly from the library now extendEasyPostExceptionwhich extends\Exception.I will add the CHANGELOG for these in the next PR which is to package up the release candidate.
Closes #7
Testing
Updates various test assertions to assure the right tests are being raised.
Pull Request Type
Please select the option(s) that are relevant to this PR.