Skip to content

fix: fixture and require tests #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 22, 2022
Merged

fix: fixture and require tests #214

merged 2 commits into from
Aug 22, 2022

Conversation

@Justintime50
Copy link
Member

@Justintime50 Justintime50 commented Aug 22, 2022

Description

Uses the new event fixture and clarifies the require test

Testing

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@Justintime50 Justintime50 requested a review from a team August 22, 2022 21:20
nwithan8
nwithan8 previously approved these changes Aug 22, 2022
View reviewed changes
@Justintime50 Justintime50 merged commit 1113831 into master Aug 22, 2022
@Justintime50 Justintime50 deleted the fix_event_require_test branch August 22, 2022 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@nwithan8 nwithan8 nwithan8 approved these changes

@jchen293 jchen293 jchen293 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Justintime50 @nwithan8 @jchen293